Remove the drupal_alter() from bootstrap.inc as it is deprecated as per meta https://www.drupal.org/node/2205673

submitted patch for the same.

CommentFileSizeAuthor
#6 drupal-2301577-6.patch885 bytesParisLiakos
remove-drupal-alter.patch796 bytesjoshi.rohit100
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Looks good! :-)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

Needs a draft change record to explain what module authors are supposed to do now if they were calling drupal_alter() before.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Issue tags: -@depreacted, -Needs change record +@deprecated, +Needs reroll

change record already exists here
https://www.drupal.org/node/1894902

but this needs a reroll now

Status: Needs work » Needs review

joshi.rohit100 queued remove-drupal-alter.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, remove-drupal-alter.patch, failed testing.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs work » Reviewed & tested by the community
FileSize
drupal-2301577-6.patch885 bytes

actually..here is the reroll ;)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 24cfbec and pushed to 8.x. Thanks!

  • alexpott committed 24cfbec on 8.x 
    Issue #2301577 by ParisLiakos, joshi.rohit100: Remove drupal_alter() as...
star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Issue tags: -Needs reroll

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Elijah Lynn’s picture

Elijah Lynn
Location Portland, Oregon
CreditAttribution: Elijah Lynn at NBCUniversal commented

Change record for this => https://www.drupal.org/node/1894902

New D8 way is \Drupal::moduleHandler()->alter($type, &$data, &$context1 = NULL, &$context2 = NULL)