Problem/Motivation

One of the remaining conversions blocking #2268761: Remove support for function-based forms

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 db-2302531-1.patch5.05 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new db-2302531-1.patch5.05 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Needs work 
  1. +++ b/core/modules/system/tests/modules/database_test/src/Form/DatabaseTestForm.php
@@ -7,16 +7,72 @@
+      'username' => array('data' => t('Username'), 'field' => 'u.name'),
+      'status' => array('data' => t('Status'), 'field' => 'u.status'),
...
+        'status' =>  $account->isActive() ? t('active') : t('blocked'),
...
+      '#empty' => t('No people available.'),

    $this->t 

  2. +++ b/core/modules/system/tests/modules/database_test/src/Form/DatabaseTestForm.php
@@ -7,16 +7,72 @@
+    $query = db_select('users', 'u');

    We can inject it. 

  3. +++ b/core/modules/system/tests/modules/database_test/src/Form/DatabaseTestForm.php
@@ -7,16 +7,72 @@
+      ->extend('Drupal\Core\Database\Query\PagerSelectExtender')
+      ->extend('Drupal\Core\Database\Query\TableSortExtender');

    '\Drupal'

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review

This is a test form. Similar to #2030165: Convert form_test_* functions to classes, I'm not fixing anything that was copy/paste.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Ok, I let the committer decide it then :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: db-2302531-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Reviewed & tested by the community

EntityCrudHookTest random fail.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: db-2302531-1.patch, failed testing.

Status: Needs work » Needs review

tim.plunkett queued 1: db-2302531-1.patch for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1b55c4f and pushed to 8.x. Thanks!

  • alexpott committed 1b55c4f on 8.x 
    Issue #2302531 by tim.plunkett: Convert database_test_theme_tablesort to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.