Patch attached.

Comments

pancho’s picture

Priority: Normal » Critical
Status: Needs review » Needs work

Oh, this does seem to be critical. The patch bloats the menu generation code even more though. I'm gonna see how I can fix this and #261989 in a code rewrite.

merlinofchaos’s picture

It might be a little clearn to do things like: if (!empty($panel_page->disabled)) { continue; }

pancho’s picture

Yeah, I'd also do it this way, if we didn't need a complete rewrite for:

  1. this one,
  2. #261989: Calculate fitness in panels_page_menu() and
  3. #264263: Variable menu items are only shown on complete match.
pancho’s picture

Status: Needs work » Fixed
StatusFileSize
new695 bytes

Oh, I figured out we need to do this one by one. And this is definitely a bugfix that needs to go into beta5. So sorry for holding this back until now, and thank you very much for catching and fixing this!
Tested and committed merlinofchaos' early-out version: http://drupal.org/cvs?commit=119289.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.