When I updated to the latest release candidate, which offers the "more" links functionality the content no longer fits in the toplist block. Essentially the entire site content appears in one long line instead of in normal columns. The previous version had no such problem.

I am using the ABAC theme.

I would have reverted to an older version of toplist but I guess they aren't retained on Drupal's site unless they are official releases. I have tried removing what I guess are the new lines of code in the toplist.module but with no luck. I guess you've made other changes?

If you send me the previous version of code I will see if I can figure out what's going on... although you probably have an idea of what's happening anyway.

Comments

olivo.marco’s picture

olivo.marco commented
Assigned: Unassigned » olivo.marco

I will check this ASAP.

Thanks for the report.
Marco

edgoss’s picture

edgoss commented

Here's a quick update. I tried the tolist block in the Salamander theme which is strict code, unlike ABAC. The same issue appeared. The entire site which should be centered ends up left justified in one long column, instead of multiple columns. Also I noticed some of the fonts have changed. I'd like to help but it's hard without the original working version of code.

Thanks for expediting this, it's a great module and I'm now having to use the old method of manually checking and updating my top list every day.

Ed

wwwoliondorcom’s picture

wwwoliondorcom commented

Hi,

I tried the new toplist module with the drigg theme and my website right sidebar is displayed under the left sidebar, so I guess this problem is related.

Thanks for this great module anyway.

olivo.marco’s picture

olivo.marco commented
Status: Active » Postponed (maintainer needs more info)

Hi, I downloaded the Salamander theme (5.x-1.x-dev - 2007-Nov-09) and installed it.
I tried both with just one referrer link and with more.
I am using Drupal 5.x, and viewing everything both with Safari 3.0.4 and with Firefox 2.0.0.12

I really can't replicate anything of what you said. Could you please try to figure out yourself which is the "wrong code" added by the module? With respect to the previous version, in fact, only a line such as:

<div id="more_linking_partners"><a href="/toplist">more</a></div>

has been added, and it can be removed by emptying the "more linking partners" field in the settings. There should be no other change.

Thanks.
Waiting for more info.

wwwoliondorcom’s picture

wwwoliondorcom commented

I don't know if this information is useful but when I put the toplist block in the right sidebar I don't have any problem, it's only when I put the toplist block in the left sidebar that the right sidebar of my website is displayed under the left sidebar on my drigg module theme.

olivo.marco’s picture

olivo.marco commented
Priority: Critical » Normal

@wwwoliondorcom: I successfully replicated your bug, but it seems more related to how the Drigg theme works with multiple

s rather than this module. In fact, if you remove the: 
<div class="item-list"><div class="toplist">

together with the closing

tags it works: the removed code however is perfectly valid at my knowledge.
Moreover, this was the same markup used before, so it couldn't be working in the older release.

edgoss’s picture

edgoss commented

It's very strange indeed. I tried removing the code you reported as new, which apparently displays the link to the main toplist page:

$output .= '

' . "\n";
if (variable_get('more_linking_partners', '') != '') {
$output .= '

' . l(variable_get('more_linking_partners', t('More...')), 'toplist') . '

' . "\n";
}

There was no affect. For the record I tested with IE 7 and IE 6 which both have the display problem. I ran a test using webshots and indeed Firefox displays correctly. Therefore this is definately a browser specific issue. Now we just have to figure out the difference between IE and Firefox that causes the problem.

I tried moving the block to the main content window, still not fixed, and to the right column, which helped somewhat. When moved to the right column the content was all displayed in the correct order and font settings but my entire site which should be centered was left justified. I'm 100% sure I didn't change anything else except update your module from the previous version, which displayed perfectly.

I guess if you had the previous version of code you would have sent it to me by now? If you can dig it up I will definately install it again and see if the problem is corrected. I have already offered to review both versions of code, but without the old one (which I guess worked for me) I am in the dark. Please send me the old code if you still have it.

I'm not sure what the solution is you mention above in post #6.? It seems like you're saying if you remove all the code that actually displays the block the bug is fixed; but then this exactly points to that code being the issue, doesn't it? I have seen issues where if the content doesn't fit into the column (say the content is 220 px wide and the column is set for 215 px) this display problem happens. In face IE 6 is more sensitive to column width issues than IE 7. This may be off base but did you used to have a bulletted list in the last version, or was that only on the main toplist page?

Again this is a fantastic module and I am sad that I can't currently use it. I will give any help I can to resolve this.

olivo.marco’s picture

olivo.marco commented

I have just released a new version which will be available in the next few hours (12 in the worst case, I think): I invite anyone that had reported display problems with the "toplist" module to try it out and tell me if there still any incompatibility with IE6/IE7, which unluckily I do not have the possibility to test.

Thanks.
Marco

olivo.marco’s picture

olivo.marco commented
Status: Postponed (maintainer needs more info) » Needs review
edgoss’s picture

edgoss commented

I just installed and tested the latest version, and the display problem is resolved in IE 7. I don't have the facility to test IE 6 at the moment but suspect it is also fixed.

Thanks!

olivo.marco’s picture

olivo.marco commented
Status: Needs review » Fixed
wwwoliondorcom’s picture

wwwoliondorcom commented

hi,

Thank you it seems ok with Drigg theme now, I just installed it and the right sidebar is on the right!

Thanks

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.