clickHeatServer and click_heatmap_display don't account for language in path

kpander - March 5, 2008 - 19:09
Project:Click HeatMap
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:boombatower
Status:closed
Description

I'm just testing out the ClickHeat module and encountered a small problem.

In a Drupal configuration without multiple languages, the url paths might look like this:

http://localhost/admin/settings
http://localhost/some_custom_path

But with multiple languages (i18n module installed), the above paths would look like this:

http://localhost/en/admin/settings
http://localhost/en/some_custom_path

This causes 2 problems.

1. click_heatmap_display() tries to determine if the current page is an admin page by checking if the first 5 characters are 'admin'. That's fine, unless the url is actually "en/admin" in which case it believes this isn't an admin page.

2. The more serious issue, click_heatmap_footer defines the clickHeatServer path by using the url function, which *includes* the language prefix, so instead of defining the location of click.php as this:

http://localhost/sites/all/modules/contrib/click_heat/etc.../click.php

It uses this:

http://localhost/en/sites/all/modules/contrib/click_heat/etc.../click.php

Which of course fails to capture any data because the url is no longer valid.

Anyways, thought I'd mention it. Sorry I don't have a patch to fix it!

Kendall
Abandoned Industry :: http://invisiblethreads.com ::

#1

boombatower - March 7, 2008 - 00:21

I am at Drupalcon and do not have access to a developement computer. I will work on this once I return home this weekend.

#2

boombatower - March 9, 2008 - 20:13
Status:active» fixed

I made the necessary changes for the 5.x and 6.x branches.

Use the new release 2.3.

#3

boombatower - March 11, 2008 - 21:40
Assigned to:Anonymous» boombatower

#4

Anonymous (not verified) - March 25, 2008 - 21:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.