using undefined variables/class members results in lots of undefined stuff warnings [#230457]

I get f.e. those:
notice: Undefined property: stdClass::$book in /var/www/web298/html/content/sites/all/modules/print/print.module on line 126.
notice: Undefined variable: query in /var/www/web298/html/content/sites/all/modules/print/print.module on line 142.
notice: Undefined variable: query in /var/www/web298/html/content/sites/all/modules/print/print_pdf.module on line 89.
notice: Undefined property: stdClass::$type in /var/www/web298/html/content/sites/all/modules/print/print.module on line 126.
notice: Undefined property: stdClass::$book in /var/www/web298/html/content/sites/all/modules/print/print.module on line 126.
notice: Undefined property: stdClass::$type in /var/www/web298/html/content/sites/all/modules/print/print.module on line 126.
notice: Undefined property: stdClass::$book in /var/www/web298/html/content/sites/all/modules/print/print.module on line 126.
right now can't be bothered to submit a patch but it should be easy to add if isset($foo) to all those lines...
else this works really nicely.. btw I would rather have those icons at the top of the relevant notes though..
another thing, the comments should be stripped from it's links (reply, edit...), I guess noone would want those on a printout :)
aight thx for your work regards

Comment	File	Size	Author
#5	undefined_variables_print_fill_attributes-230457.patch	897 bytes	ultimike

Comments

Comment #1

jcnventura

English

commented 5 March 2008 at 22:55

Status:

Active

» Postponed (maintainer needs more info)

How do you get these warnings? I never saw any of them..

Do you use

João

Comment #2

eMPee584 commented 6 March 2008 at 02:41

well you have to torn on error reporting in the drupal config... only warnings but ugly nonetheless, it seems most people and even module devs have them switched off...
by the way the coder module has a code review feature try that if you feel like it ;)

Comment #3

jcnventura

English

commented 6 March 2008 at 08:58

Hi,

Thanks for the info. In an unrelated patch, merged yesterday, I think you will no longer see the 'query' undefined variable messages. The remaining two undefined properties will require a specific line checking if they are set.

I do use the coder module regularly, btw..

João