Attached patch adds the more link only if the number of returned nodes is superior to the number of nodes per page.

Comments

yched’s picture

StatusFileSize
new816 bytes

Updated - the previous patch always hid the 'more link'.

sdboyer’s picture

Status: Needs review » Postponed (maintainer needs more info)

Hi yched -

I thought I understood what this patch was intended to solve from your description and it seems like something clean and simple that I should absolutely commit for beta3. But, I've tried to get it working on my local sandbox and haven't been able to replicate the problem it's intended to fix - could you provide a little more information about the circumstances under which this problem with the 'more' link occurs? Thanks!

cirotix’s picture

Replying for yched : the problem is that if the number of returned nodes in a pane-view is smaller than the number of nodes that can be displayed, the "more" link still appears (and it shouldn't). The patch fix that.

sdboyer’s picture

It's been a while since I tried to recreate this, but I'll give it another shot now. I vaguely remembering noticing when I debugged that the max nodes # clamped down when the number of nodes returned was fewer than the max, but it's been a while, so I'll see if I can't reproduce it now.

sun’s picture

Status: Postponed (maintainer needs more info) » Needs review

Confirming that this bug still exists.

sun’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new858 bytes

Confirming that this patch fixes this bug.

Re-rolled.

sdboyer’s picture

Status: Reviewed & tested by the community » Fixed

Sorry for the rather dumb delay on this one. I've committed the changes.

Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.