http://drupal.org/node/22019

The book page on converting XTemplate themes to PHPTemplate seems incomplete. Attached is a text file with some corrections.

Cheers.

Comments

gordon’s picture

can you please create a diff between the 2 pages, or hilight in your submitted document what has changed, This will make it so much easer for me to check and incorporate the changes into the page.

Thanks.

pfaocle’s picture

StatusFileSize
new1.52 KB

Here you go.

gordon’s picture

Thanks for this. applied to documentation.

Anonymous’s picture

pfaocle’s picture

The page is still incorrect.

gordon’s picture

sorry I missed some of the updates, they are now in place waiting on approval.

Anonymous’s picture

pfaocle’s picture

Status: Closed (fixed) » Active

I've no idea whats going on here - this page is still incorrect.

pfaocle’s picture

Status: Active » Needs review

Updated patch for changes, too.

cel4145’s picture

I'd be glad to update the handbook page if you'll post a corrected html version of the full text (non-coder here who doesn't work with diff's :-)

pfaocle’s picture

StatusFileSize
new2.12 KB

Jesus Nora, give me permissions to edit that page and I'll do it myself...

Text attached.

pfaocle’s picture

StatusFileSize
new1.29 KB

Here's the diff I forgot to submit last night, too.

gordon’s picture

Assigned: Unassigned » gordon
Status: Needs review » Fixed

applied changes, it does need to go through the revision queue, bu should not take too long to apply.

If you want write access, you will need to talk to the documentation team.

cel4145’s picture

Status: Fixed » Closed (fixed)

The page has been approved.

In the future, you can edit the page directly and it will enter the moderation queue.