// Line 278
// before:
'#description' => t('Report information about wrong responses to the !watchdoglog.', array('!watchdoglog' => l('log', 'admin/logs/watchdog'))),
// after:
'#description' => t('Report information about wrong responses to the !watchdoglog.', array('!watchdoglog' => l(t('log'), 'admin/logs/watchdog'))),

and

// Line 520
// before:
      '#title' => 'CAPTCHA',
// after:
      '#title' => t('CAPTCHA'),

Please fix:)

Comments

soxofaan’s picture

soxofaan commented
Status: Active » Fixed

done (your second suggestion was already fixed)
http://drupal.org/cvs?commit=104882
http://drupal.org/cvs?commit=104883
http://drupal.org/cvs?commit=104884

a.a.egoroff’s picture

a.a.egoroff commented
Status: Fixed » Needs review

Additional 3 bytes. I have checked up revision 1.66, and given below fix is absent.

// Line 43
// before
'%skipcaptcha' => 'skip CAPTCHA',
// after
'%skipcaptcha' => t('skip CAPTCHA'),

Help please to the beginner:
What it is better, to reopen issue or to create new if I find small corrections like this one?
What status and priority should be appointed to similar fixes?
How it is more correct and more convenient for developers to publish issues?

Thanks for your work:)

soxofaan’s picture

soxofaan commented
Status: Needs review » Fixed

http://drupal.org/cvs?commit=105020 (DRUPAL-5--3)
http://drupal.org/cvs?commit=105021 (DRUPAL-6--1)
http://drupal.org/cvs?commit=105022 (DRUPAL-HEAD)

reopening was ok since the issues are related, but opening a different issue would be ok also
I would label this as minor priority.
As you did not provided real patches (see http://drupal.org/patch), status should be "active", not "patch something"

thanks

a.a.egoroff’s picture

a.a.egoroff commented
Status: Fixed » Needs review

Oops! Forgot one:

// Line 204
// before
    '#description' => t('This option is very helpful to enable/disable challenges on forms. When enabled, users with the "%admincaptcha" permission will see CAPTCHA administration links on all forms (except on administrative pages, which shouldn\'t be accessible to untrusted users in the first place). These links make it possible to enable a challenge of the desired type or disable it.', array('%admincaptcha' => 'administer CAPTCHA settings')),
// after
    '#description' => t('This option is very helpful to enable/disable challenges on forms. When enabled, users with the "%admincaptcha" permission will see CAPTCHA administration links on all forms (except on administrative pages, which shouldn\'t be accessible to untrusted users in the first place). These links make it possible to enable a challenge of the desired type or disable it.', array('%admincaptcha' => t('administer CAPTCHA settings'))),
a.a.egoroff’s picture

a.a.egoroff commented

Real big thanks for this link http://drupal.org/patch!!!

soxofaan’s picture

soxofaan commented
Status: Needs review » Fixed

the fix for #4 was already included in the commits mentioned in #3

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.