Hi,
I'm using Schema module on my Drupal6 site. and it shows tables for which the schema and database are different.

int_meta_fields.type is part of the primary key but is not specified to be 'not null'.

  • int_meta_fields
    • column type:
      declared: array('type' => 'varchar', 'length' => 32, 'not null' => FALSE)
      actual: array('type' => 'varchar', 'length' => '32', 'not null' => TRUE, 'default' => '')
    • column type:
      declared: array('type' => 'varchar', 'length' => 32, 'not null' => FALSE)
      actual: array('type' => 'varchar', 'length' => '32', 'not null' => TRUE, 'default' => '')

Thank you for your work.

Comments

fractile81’s picture

fractile81 commented
Component: int_meta_cck.module » Code
Status: Active » Postponed (maintainer needs more info)

Interesting. I actually did that on purpose, with a default being set. As implemented today, the "default" configuration is an empty string as opposed to a NULL value in that table. NULL would thus not make any sense since it would be meaningless to the code.

Do you have any links on best practices for something like this? I'm willing to re-evaluate how the schema is setup if I can understand why one way is better than the other.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

It is always suggested that primary keys are set to be NOT NULL.
If the code doesn't assign NULL values to the primary keys, that is a reason more to set the primary keys to NOT NULL; if the code would assing a NULL value to the primary keys, then the code should be changed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Active
fractile81’s picture

fractile81 commented
Status: Active » Patch (to be ported)

I've fixed this internally in D6, but still need to port it to the D5 branch.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Database schema Mismatch » Primary keys are declared NULL
fractile81’s picture

fractile81 commented
Status: Patch (to be ported) » Fixed

The Schema module no longer shows the schema from this module as mismatched anymore in the BETA6 release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.