Closed (fixed)
Project:
Organic Groups Subscriptions
Version:
5.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
8 Mar 2008 at 22:24 UTC
Updated:
9 Mar 2008 at 01:50 UTC
According to drupal conventions variables whose names start with an underscore are global variables. Local variable names should not start with an underscore. I think fixing this will only require a global search and replace replacing every occurence of $_ by $
Comments
Comment #1
gustav commentedPlease use the coder module (http://drupal.org/project/coder) to check compliance of the code with the drupal guidelines. It currently shows up a lot of warnings.
Comment #2
develcuy commentedThank you gustav, I've changed $_ by $
Just for commenting, I've asked to chx about naming conventions for global variables, he said that drupal core is not using that naming convention but they have to fix the core, hope they are going to fix it for D7(I will report that task)
Blessings!
Comment #3
develcuy commentedI've don't seen your last comment, now code is according to drupal guidelines.
That wonderful coder.module really rocks.
Blessings!