The function _privatemsg_prune() relates to a column named 'type' in 'privatemsg_archive' table. This generates an error and practically holds all cron runs on site.
Just wondering you have column defaults setup via the privatemsg_update() function but there
are no defaults setup in the privatemsg_install() function.
There is only one INSERT to this table in the module right now and there is a supplied value
for the 'type' column so in theory there does not need to be a default. Probably should
update the patch to be consistent between the hook_install and the hook_update depending
on what the desired status of setting a default or not is.
You are probably right, I didn't get into that level of code review, I just copied a similar 'type' column from another table in this module, figuring they should be the same.
The patch should be fixed, but I can't test it at the moment.
Please note I marked this critical since not applying this patch meant for me no cron ever runs on the site.
Sorry for pinging the participants, I am closing old issues.
This version of Privatemsg is not supported anymore, maybe it is already implemented in Privatemsg for Drupal 6 and if not, you are welcome to open a new issue for it.
Comments
Comment #1
jaydub commentedJust wondering you have column defaults setup via the privatemsg_update() function but there
are no defaults setup in the privatemsg_install() function.
There is only one INSERT to this table in the module right now and there is a supplied value
for the 'type' column so in theory there does not need to be a default. Probably should
update the patch to be consistent between the hook_install and the hook_update depending
on what the desired status of setting a default or not is.
Comment #2
yhager commentedYou are probably right, I didn't get into that level of code review, I just copied a similar 'type' column from another table in this module, figuring they should be the same.
The patch should be fixed, but I can't test it at the moment.
Please note I marked this critical since not applying this patch meant for me no cron ever runs on the site.
Comment #3
berdirSorry for pinging the participants, I am closing old issues.
This version of Privatemsg is not supported anymore, maybe it is already implemented in Privatemsg for Drupal 6 and if not, you are welcome to open a new issue for it.