Closed (fixed)
Project:
Node clone
Version:
6.x-1.0-beta1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
9 Mar 2008 at 16:59 UTC
Updated:
9 May 2014 at 01:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pwolanin commentedeasy enough - can you the patch?
Comment #2
jredding commentedNot highly tested (read not tested at all) but this does the trick.
If the user has the "Clone node" permission they can clone everything
If the user has the "Clone own nodes" permission they can only clone their nodes. Obviously you wouldn't want to give both permissions together so its possible there is a better way to word/code this.
Comment #3
shawnpetriw commentedCool - I'll give it a shot.
Comment #4
shawnpetriw commentedThis works great - just as expected. I think it would be good to add to the next release.
I'll let you know if there are any issues on my site.
Comment #5
pwolanin commentedfor consistency maybe "clone own node"?
Comment #6
jredding commentedhhmm...
"clone own content" is more consistent with Drupal..
"clone own node" is consistent with this module.
You make the decision and I'll roll a new patch.
Comment #7
shawnpetriw commentedI say stay with the Drupalise version - "clone content."
Also given the issue with CCK image fields and other file attachments (http://drupal.org/node/249049, http://drupal.org/node/200092), I am REALLY glad you offered this granular permission - it keeps from somebody messing up the pictures in someone else's content by cloning and deleting.
Comment #8
pwolanin commentedhmm, maybe I should bite the bullet and change the permission name in 6.x?
Comment #9
jredding commentedI say change it in 6.
New permission would be
"Clone content"
"Clone own content"
in 5.x leave it as
"clone node"
"clone own nodes"
but we can change it to "clone own node" if you want. I'll roll whatever patch you want just tell me your decision ;)
Comment #10
pwolanin commented@jredding - the fun part is updating the permissions from 5.x to 6.x...
here's how I did it for book module:
http://api.drupal.org/api/function/book_update_6000/6
Comment #11
pwolanin commentedpatch does not apply - here's a new one for 5.x-2.x
Comment #12
pwolanin commentedfor the 5x-1x
Comment #13
pwolanin commentedcommitted this patch and the previous for the 5.x versions
Comment #14
pwolanin commentedbasic patch for 6.x - please test. Doesn't do permission re-naming, if that's desired.
Comment #15
pwolanin commentedquick test looks ok - committing to HEAD - let me know if anything explodes.
Comment #16
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.