Project API terms are generated in the wrong order

aclight - March 9, 2008 - 18:16
Project:Drupal.org Testing
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:aclight
Status:closed
Description

Currently, API compatibility terms are generated in the order of most recent to earliest (ie. 6.x to 4.0.x). They need to be generated in chronological order (ie. 4.0.x to 6.x). Attached patch fixes this.

AttachmentSize
dot_api_term_order.patch896 bytes

#1

dww - March 19, 2008 - 08:25
Status:needs review» needs work

Sure. Might as well add 7.x while you're at it.

#2

aclight - March 19, 2008 - 11:10
Status:needs work» needs review

Yep, might as well. Here's an updated patch. I haven't yet tested this updated patch.

AttachmentSize
dot_api_term_order_2.patch 971 bytes

#3

dww - March 19, 2008 - 17:33
Status:needs review» needs work

Actually, if what you're worried about is the order of the terms, I'm pretty sure you need to specify the weight for each term, not just change the order they're submitted in. Since we want a reverse chronology order in the various term listings, we want to weight the oldest terms the heaviest and keep getting lighter as we get newer. That's actually how the code worked during the initial conversion to the "new" release system...

#4

aclight - March 21, 2008 - 01:55
Status:needs work» needs review

Yep, good point. This does the trick.

AttachmentSize
dot_api_term_order_4.patch 1.26 KB

#5

dww - May 16, 2008 - 00:12
Status:needs review» reviewed & tested by the community

Great, ship it. Thanks!

#6

aclight - May 16, 2008 - 12:19
Assigned to:Anonymous» aclight
Status:reviewed & tested by the community» fixed

Fixed in http://drupal.org/cvs?commit=116521

#7

Anonymous (not verified) - May 30, 2008 - 12:21
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.