End the endless debates and provide a theme overrideable hook for include misc/drupal.css. The idea (partially) comes from FactoryJoe.

CommentFileSizeAuthor
theme_settings_0.patch913 byteschx

Comments

Thox’s picture

Thox commented

+1 for sure. Backwards compatible and makes FactoryJoe happy.

factoryjoe’s picture

factoryjoe commented

Hey if it makes me happy, how can I not +1?

So this is the logic of this patch, to quell the whole drupal.css controversy once and for all... Since themes can override themable functions, I proposed doing something similarly drupally for the drupal.css issue. Basically if a theme provides its own drupal.css, it should use that to override the default. If the theme doesn't, then the usual 'misc/drupal.css' file is linked.

CHX implemented this solution in 10 seconds and seems to accomplish both protecting the backwards compatibility of themes that reply on drupal.css while giving wacky themers like myself the ability to override drupal.css completely.

Nice. +1.

kbahey’s picture

kbahey commented

+1.

Each side can have it their way.

Those who want drupal.css to stay can now focus the discussion on improving it, and not "to be or not to be" arguments.

Bèr Kessels’s picture

Bèr Kessels commented

Why can't factoryjoe override theme('stylesheet_import', 'misc/drupal.css'); ? Allright, it needs a little logic to pass all other stylesheets, but not 'misc/drupal.css', but that is as hard as a sinle if statement.
+1 on Making Chris happy. -1 on this patch :)

dries’s picture

dries commented

Why? It is already possible to overwrite the stylesheet. This looks like cruft to me.

chx’s picture

chx commented
chx’s picture

chx commented

For the archives: I have written http://drupal.org/node/23215 to show the way Ber and others pointed at.