Replace SimpleTest browser with our own

This needs be rerolled.

ok, so from chx, the easiest way to setup to test this is to move the Soureforge version to somewhere else and just copy the files listed at the top to simpletest/simpletest

After fixing the .info file (note error in patch 7.x->6.x) A quick check on 7.x (HEAD) is functional; however, problems with the poll module tests (the only ones I ran):

51 passes, 16 fails and 0 exceptions.

even after adding $this->elements = FALSE; to curlExec in drupal_test_case.php as suggested by chx

Not sure where I can provide feedback on the changes necessary to get simpletest, or a deriviate thereof, in core. One of the small things that annoy me is the desc field used in the get_info hook. For consistency with core, that should be called description instead of desc.

Edit: opened a separate issue at http://drupal.org/node/235013 . [chx]

Possibly change the message in the handleForm function.

You tried to change a !type select to !edit and that's not allowed.

to

You tried to change a !type to !edit and that's not allowed.

Example:

You tried to change a textarea to somevalue and that's not allowed.

Obviously nothing big.

Other small thing: the patch change the info file core to 6.x. Technically this will all be committed to HEAD (7.x).

Other than that it is looking nice.

From the looks of the patch it appears you are fixing general things as well. Just trying to keep it straight for record.

patch fails on simpletest HEAD checkout

patching file tests/functional/node.test
Hunk #1 FAILED at 7.
Hunk #3 FAILED at 116.
Hunk #5 FAILED at 263.
3 out of 8 hunks FAILED -- saving rejects to file tests/functional/node.test.rej
patching file tests/functional/poll.test
Hunk #2 FAILED at 40.
Hunk #3 succeeded at 65 with fuzz 2.
1 out of 3 hunks FAILED -- saving rejects to file tests/functional/poll.test.rej

When I run any tests that uses a form (which should be all of them) it generates the following exception many times.

Unexpected PHP error [Undefined variable: handled] severity [E_NOTICE] in [/home/jimmy/software/php/simpletest/drupal_test_case.php line 588]

Code:

588: if (!isset($post[$name]) && !$handled) {

I'm going to guess that $handled needed to be initialized, but it doesn't appear that $handled is used in the code anymore. Possibly just left over?

Tests run fine without it:

588: if (!isset($post[$name])) {

I made the change above and committed.