RSS Feeds have invalid date
ntiostle - March 10, 2008 - 16:59
| Project: | Drupal |
| Version: | 6.12 |
| Component: | node.module |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
Hi!
The W3C feed validator says that:
Sorry
This feed does not validate.
line 16, column 40: pubDate must be an RFC-822 date-time: Mo, 10 Mär 2008 17:42:43 +0100 (30 occurrences) [help]
<pubDate>Mo, 10 Mär 2008 17:42:43 +0100</pubDate>Obviously the date is being localized what is not RFC-822 conform. (Mär instead of Mar)
I will provide more information if needed!
Andreas
#1
Same problem with 6.1 and french langage.
puDate had to be in EN .
(with rss feeder (Thunderbird, google, aggregator of drupal ...) All rss have the same date.)
rss.xml is OK, but not /blog/feed
Thank you
#2
Same problem
Drupal6.1
French
Invalid PubDate format
rss.xml not OK
Thx
#3
Give this patch a try. I haven't tested it myself because I don't have any translations but theoretically it should fix the problem. It simply forces the date to be in English when filling in the pubDate field contents for the feed.
#4
Tested, seems ok for me...
#5
...If we can get one more person to test this, I'd be happy to bump it up a notch so that the change gets committed. As mentioned previously, I don't have the localisation framework to test it myself.
It's a quite serious bug for anybody not on an English default system; as all their feeds are non-validating and potentially unusable. It would be quite appropriate IMHO to mark it as 'critical'.
#6
Just tested this and it works for me (german language).
This patch should be added as soon as possible, as all 6.1 users seem to have the same issue with their rss-feeds if they changed their installation from english-default.
Thx
#7
Hum. I don't really understand why there is not the same problem on Drupal 5. Could someone clarify that?
From
node_feed()in Drupal 5:array('key' => 'pubDate', 'value' => format_date($item->created, 'custom', 'r'))... and
format_date()does not support the$langcodeargument, which has been added in Drupal 6.#8
Oh, and (if confirmed) this is critical (it breaks the whole feed creation mecanism), and bugs should get corrected in the current development version, than back-ported.
#9
The patch is not formatted properly and therefore won't apply. It needs to be re-rolled with proper line-breaking. Thanks.
#10
Patch re-rolled - not certain how the lines got folded.
#11
File was patching node.module.orig, which doesn't exist. Fixed in attached patch.
Besides the very long line of code (which was already there before), this looks good.
#12
This is a critical bug for drupal 6.
Here's what I think is a more correct patch: the formatting has to be correct so we should use PHP date functions, not format_date().
#13
+1
I concur.
#14
Fixing component.
#15
I've committed this patch to CVS HEAD and DRUPAL-6. Thanks mfb.
#16
#17
Automatically closed -- issue fixed for two weeks with no activity.
#18
#212864: rss feed wrong date was also committed to the DRUPAL-5 branch, but only got released yesterday with Drupal 5.8. Here is a reroll.
#19
Committed to 5.x.
#20
Automatically closed -- issue fixed for two weeks with no activity.
#21
Still have the same problem with the latest version of drupal
#22
@Jaafarix: Not sure why there'd still be an issue since this patch is in 6.12: http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/node/node.module?a...
#23
Yes I checked the patch against 6.12 and it is there. Still the publication date are in french for me, both with views and rss.xml and the feed does not validate.
I removed the date for now thanks to theming but it would be nice to have the english date in feed instead of the french one
#24
@Jaafarix: what you are seeing is a Views issue. Please see #461842: Views translates pubdate of rss feed for details.
#25
I tried the patch and i have english dates now.
Thank you very much :).