My theme breaks the help list at admin/help, and the list function help_links_as_list makes too many assumptions about my layout.

This patch makes a theme function out of the part that outputs the complex layout. The performance cost is that the list of modules array is looped again in the theme function.

CommentFileSizeAuthor
#5 232466-5-theme_help_topics.patch2.54 KBpasqualle
#2 theme_help_links.patch1.72 KBAnonymous (not verified)
theme_help_links.patch668 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

ok. so i'm a super fool. i really thought i tested this patch! ignore it for now.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new theme_help_links.patch1.72 KB

this is the real patch.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Closed (won't fix)

Drupal 6.x allows for the maintenance theme to be changed via settings.php and has improved database connection errors. The latter change may be backported to Drupal 5.x if anyone takes it on. Otherwise, this is either redundant or a project for the development version, currently Drupal 7.x.

drumm’s picture

drumm
he/him
Location NY, US
commented
Version: 5.x-dev » 7.x-dev
Status: Closed (won't fix) » Needs work

Please disregard the previous review, it was meant for another issue.

Feature changes, such as new themeable functions, are not being added to the stable versions of Drupal, currently 5.x and 6.x. Instead, they should be added to the development version, currently 7.x or CVS HEAD.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Title: theme help_links_as_list » theme help topics
Category: feature » bug
Status: Needs work » Needs review
StatusFileSize
new 232466-5-theme_help_topics.patch2.54 KB

Status: Needs review » Needs work

The last submitted patch, 232466-5-theme_help_topics.patch, failed testing.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs work » Needs review

#5: 232466-5-theme_help_topics.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 232466-5-theme_help_topics.patch, failed testing.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs work » Needs review

#5: 232466-5-theme_help_topics.patch queued for re-testing.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

finally..

aspilicious’s picture

aspilicious commented

Still applies.
A proper review from a theme specialist and this one can get in.

ff1’s picture

ff1 commented

#5: 232466-5-theme_help_topics.patch queued for re-testing.

ff1’s picture

ff1 commented
Status: Needs review » Needs work

Applying the patch in #5 completely removed the list of help topics at /admin/help.

Steven Brown’s picture

Steven Brown commented
Version: 7.x-dev » 8.x-dev

This issue needs to be worked on in the 8.x-dev branch and then if seen fit backport it to the 7.x-dev branch. This helps to prevent regressions.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue summary: View changes
Status: Needs work » Closed (duplicate)
Related issues: +#1986164: Improve the way main help page is rendered

This issue is duplicated in
#1986164: Improve the way main help page is rendered
and that one seems more active, so I'm closing this one as a duplicate.