Hello

I am trying to install notifications in a drupal 5.7 site, and have the following error after enabling the module:

warning: Missing argument 1 for notifications_module_info() in /home/humanizasus/htdocs/modules/notifications/notifications.module on line 537.

Any clues?

CommentFileSizeAuthor
#10 notifications-232610.patch4.02 KBjody lynn

Comments

visionquest’s picture

I just had the same problem.

Line 537 is:

function notifications_module_info($op, $arg0 = NULL, $arg1 = NULL, $arg2 = NULL) {

The error message says "Missing argument 1" so I changed it to this and it works fine:

function notifications_module_info($op = NULL, $arg0 = NULL, $arg1 = NULL, $arg2 = NULL) {

However I am not a coder so if this change could be confirmed as correct I would appreciate it.

Cheers,

Noel

jose reyero’s picture

Status: Active » Fixed

The first parameter for this function is mandatory, it doesn't make sense otherwise.
I cannot reproduce it and I think with the clean up we've been doing this should be gone re open if persits with latest versions.

jody lynn’s picture

Status: Fixed » Active

This is still an issue with latest version. To reproduce, go to admin/build/modules and hit submit.

jody lynn’s picture

visionquest, do you use workflow_ng? I think it is a conflict with that module.

jody lynn’s picture

Yeah, I think workflow_ng is using a hook_module_info which is calling notifications_module_info accidentally. I'll post the issue to that project.

jody lynn’s picture

jose reyero’s picture

Category: support » bug

Well, now you guys have found the cause of the bug, this should be easy to fix, I'll just change the notifications_module_info() function name...

(I've closed the issue for workflow-ng btw)

jody lynn’s picture

Thanks Jose. (And I think you are the Jose we smoked cigarettes with at Drupalcon?) I agree with your assessment on the other thread.

jody lynn’s picture

Jose, what would you like the function to be renamed as? I can make a patch for it (the error message is driving me nuts)

jody lynn’s picture

Status: Active » Needs review
StatusFileSize
new4.02 KB
jose reyero’s picture

Title: Error on install » Function name conflict with other modules
Status: Needs review » Fixed

Thanks a lot!

It seems there are other modules using that name too :-)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.