Drupal 6 port for ImageCache
Eaton - March 11, 2008 - 01:43
| Project: | ImageCache |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Here's a port of the core functionality for ImageCache, accompanied by a port of ImageAPI (http://drupal.org/node/232623). There are likely to be some bugs, still, and display of action settings in the preset table are borked because of the new need for hook_theme() -- I think it makes sense just to make those settings functions callbacks rather than theme functions, as there's no real use case for overriding them.
CCK Formatter integration is still unfinished, but other than that it should be ready to check out.
| Attachment | Size |
|---|---|
| imagecache_6.patch | 52.6 KB |
#1
Also, page titles for sub-pages are janky. Need to move the title-setting code from the menu hooks to the individual pages.
#2
Whee, here's a version that fixes the menu title funkiness. It uses some of the slightly crazy menu loading magic to translate the titles, and so on.
#3
(Oh... and the imagecache preset form, where actions can be re-ordered, now uses tabledrag.js to avoid the ugly weight fields).
#4
Whoops. Missed a couple menu titles.
#5
I'm having problems getting this to work. The files aren't being created and I'm not quite sure where the problem is. It's a new host and a new 6.x install so it might be something as stupid as file permissions or a screwy .htaccess. While trying to debug it I came across one other thing.
Looking at the preset settings (e.g. admin/build/imagecache/preset/1) I'm noticing that the 'Settings' column is empty. imagecache_ui_preset_form() is setting:
$action_form['settings'] = array('#theme' => $action['action'],
'#value' => $action['data'],
);
which leads me to think that the theme function isn't being registered correctly. Looks like we need to add:
theme_imagecache_resize and the contents of imagecache_actions.inc to image_cache_theme().
Once I figure out my issue I'll look at updating this patch.
#6
when i enable private files imagecache works, with public files imagecache_cache() never gets called. i can't say that it's not a problem with my server and mod_rewrite though.
the attached patch add the theme functions to imagecache_theme().
#7
Thanks! I can't help but think that the theme functions might be overkill in the D6 model; why not make them a callback defined in the action structure, given the fact that they are only displayed in the administration table?
#8
eaton, probably right about not needing the full theme functionality... a call back sounds like the right approach. if there's a usecase for changing the callback we can just send the actions through a call to drupal_alter() so other modules can hack on them.
#9
Can anybody provide the complete files? i've build the new files with the patches, but the module doesn't work :-(
#10
freakx0, what didn't work? also, did you try private file transfers?
#11
just wanted to note that turned on public file transfers to test it out again and it was working.
#12
it turns out that it's not working quite right, the images are only created when private file transfers are enabled but will be served correctly in either mode.
#13
fixed the menu access to be compatible with D6.2.
#14
forgot to fix the access in imagecache_ui.module...
#15
now that quicksketch has a patch for imagefield i started working on getting the field formatters updated. the as link to the node doesn't work yet because i can figure out where to find the node id.
#16
default formatter wasn't working...
#17
Which version should I check out and apply the patch to? I will try to test this imagecache6 with the imagefield patch6_5.
Was the private/public file transfer issue solved?
#18
can someone please provide patched file for drupal 6.2? this patches get quite messy - complete download would be extremely helpful for non full time developers ;)
#19
Thanks for this one guys it's working a treat for me with imagefield at the moment.
To anyone reading please note that the current HEAD copy of the module has been updated since this patch was started which causes some nasty breakages if you try to apply the patches to them. I am reluctant to attach a full fileset for the module as it will likely be out of date almost as soon as it is attached.
Instead here's how you get it to work:
cvs -d ":pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib" checkout -D "March 11, 2008" -r HEAD -d imagecache contributions/modules/imagecache
cd imagecache
[download the latest patch file into the image cache folder]
patch < [patch filename here]
rejoice in the imagecache goodness
#20
just a note... I won't be supporting merged code sources from unofficial releases.. I really suggest you only use the 6.x port if you're really comfortable with the code... I'm still working on 5.x-2.x in HEAD and it will be a moving target until I'm done.
#21
well, it seems like March 11th, 2008 rep is empty. i've used latest one but patching gave me quite few errors :/
#22
no joy with patching
take it that from the above post the version patched against is no longer available from the cvs?
any change of putting up already patched version
or if not the module version itself that needs to be patched
thanks
#23
I would also like to test this port.
#24
totally untested re-roll...
#25
Thanks drewish, the patch worked perfectly.
When I visit admin/build/imagecache, none of the links (edit, remove, flush) seem to do anything other than changing the URL to admin/build/imagecache/preset/1.
#26
psynaptic, thanks for the testing looks like i'd accidentally removed one of the menu wildcard loader functions thinking it was unused. moved it from imagecache.module to imagecache_ui.module and updated the name accordingly.
please keep banging away at it.
#27
[don't mind me, just subscribing]
#28
lol, drewish your patch is already out of date. 8 hours ago cvs got updated. please provide full patched module. original sources change so fast that we won't be able to patch them anyway :(
#29
I'd say just an updated patch would be good.
#30
here's a re-roll... i won't post full versions of the module. patches are pretty simple to apply and if you're not comfortable enough to get the patch applied you probably shouldn't be messing with beta code. because you can always get old versions out of cvs.
#31
thanks.
it's not that i'm uncomfortable with patching. it's not a problem. the real issue was that every time i've came to this thread your patches turned out to be already outdated :)
anyway thanks for re-roll this time i've made it on time ;)
i hope we'll get new 6.x branch soon because this module is almost a must-have for every site.
#32
patch goes ok
but get blank screen on the next page after enabling imagecache module
would I be right in thinking its something to do with permission issues?
#33
mikehh, well assuming you installed imageapi and applied the D6 patch, pull php's error log and provide some detail. what was the error message?
#34
fixed a problem with the requirements checking. on a clean i'd tried enabling imagecache_ui and imageapi_imagemagick thinking it would detect the dependency and enable the required modules... didn't quite work. i got a fatal error because imagecache_requirements() was calling imageapi_get_available_toolkits() which wasn't defined. i tried changing it so that if the function was not defined i returned a requirements error which worked better but caused a new problem: trying to enable the same two modules sort of worked, imagecache_ui was enabled but listed with a missing dependency and imagecache was disable but the checkbox to enable it was disabled. the simplest fix was to just make the toolkit a runtime requirement just like the imagecache_directory checks.
#35
which version of imagecache should this patch be applied to? I have gotten errors on the versions i have tried applying it to.
#36
Subscribing.
#37
New Patch:
- Updated to HEAD
- Modified hook_theme() and imagecache_field_formatter() so that Imagecache now works with Views in 6.2 - needs further testing.
Possible bugs:
- Cache may need to be flushed each time a new Imagecache preset is added/renamed for Views support.
#38
Updated Patch:
- Updated two l()'s from 5.x style to 6.x style
#39
Updated patch:
- Runs drupal_rebuild_theme_registry() after new Preset is defined.
#40
subscribing to know what's going on
#41
Untested patch against latest version of 5.x dev (may 20)
#42
I tried this, patch applied successfully but it still shows up as "incompatible" with my Drupal 6.2 installation.
I've actually been trying all day to get some version of ImageCache working on Drupal 6.
If anyone can help that would be awesome!
#43
What version are you patching against? You have to patch this against HEAD.
#44
Right, that's what I was trying:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/imagecache/
And I have tried these patches:
http://drupal.org/files/issues/imagecache-6.0-232624-3.patch
http://drupal.org/files/issues/imagecache_232624_7.patch
http://drupal.org/files/issues/imagecache_6_0.patch
None of them complete cleanly. Which one SHOULD I be using at this point?
#45
@Vigile,
Download every file from: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/imagecache/...
Use the patch I posted at #39
I just did this myself and it patched perfectly. I can also confirm that it works enough to play with on a development site.
Edit: To make things a bit easier for you I have attached a working version that I just patched from HEAD seconds ago, hope this helps with testing.
@Steve Dondley
I looked at your patch briefly can confirm that it will not work as it is missing some crucial information in the .info file.
Is there anything in your patch that mine does not have?
#46
@Deciphered
Right, my patch only covers the .module file. An oversight on my part.
My patch was created with your patch from #39. Your patch did not apply cleanly because HEAD had moved. So I patched in the failed hunks manually. If I recall, one of the hunks was just thrown away because it wasn't needed any longer.
#47
@Deciphered - That got it working - many thanks! I'll play around and see how it goes!
#48
just to keep everyone on the same page, here's a re-roll of Deciphered's last patch. it seems to be working pretty well for me.
#49
subscribing
#50
Applied and tested #48 and it seems to work pretty well.
#51
Sounds like we might be inching towards RTBC?
dopry, I see that a stable release of 5.x-2.x is out now. Does that mean the majority of your changes are complete, or are you still doing some refactoring there?
#52
subscribing to this valuable effort
#53
...
#54
Hm. This patch doesn't apply against 5.x-2.x, and it looks like that's where active development is going on (last commit in 5-x-2.x was 8 days ago vs. 2 weeks ago in HEAD).
patching file imagecache.infopatching file imagecache.install
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file imagecache.install.rej
patching file imagecache.module
Hunk #1 FAILED at 1.
Hunk #12 FAILED at 507.
Hunk #13 FAILED at 537.
Hunk #14 succeeded at 531 (offset -28 lines).
Hunk #15 succeeded at 546 (offset -28 lines).
Hunk #16 succeeded at 572 (offset -28 lines).
Hunk #17 succeeded at 598 with fuzz 1 (offset -28 lines).
Hunk #18 succeeded at 624 (offset -30 lines).
Hunk #19 succeeded at 732 (offset -40 lines).
Hunk #20 succeeded at 747 (offset -40 lines).
Hunk #21 succeeded at 759 (offset -40 lines).
Hunk #22 succeeded at 769 (offset -40 lines).
Hunk #23 FAILED at 791.
Hunk #24 succeeded at 802 (offset -42 lines).
Hunk #25 succeeded at 826 (offset -42 lines).
Hunk #26 succeeded at 834 (offset -42 lines).
Hunk #27 succeeded at 844 (offset -42 lines).
Hunk #28 succeeded at 863 (offset -42 lines).
Hunk #29 succeeded at 871 (offset -42 lines).
Hunk #30 succeeded at 885 (offset -42 lines).
Hunk #31 succeeded at 917 (offset -42 lines).
Hunk #32 succeeded at 963 (offset -42 lines).
4 out of 32 hunks FAILED -- saving rejects to file imagecache.module.rej
patching file imagecache_actions.inc
patching file imagecache_ui.info
patching file imagecache_ui.module
#55
@webchick, try my patch at #41 (does not patch install/info files though).
#56
Here is a working patch against 5--2.
#57
subscribing...
#58
followup #56 committed to HEAD... I'll be doing some follow up fixes... Create new issues for head if it's broken now, but give me a day to work some kinks out.
#59
Automatically closed -- issue fixed for two weeks with no activity.
#60
sub
#61
sub
#62
Subscribing
#63
seriously... why are you people subscribing to a closed issue when there's a D6 release available for testing?
#64
I guess for 2 reasons:
1. they are not aware of it
2. they want latest news - that version is in head, not even dev yet
Anyway, you're right - there should be another issue about latest development and link to it posted here.
#65
I'm subscribing because in the web 2.0 world I've become quite accustomed to having information I want come to me rather than continually searching until the answer becomes available and this seem to be the most likely place for that answer to show up. If someone creates another issue to track the release of an RC or whatever I'm sure you'd see a mass sub on that issue as soon as it is posted here. Basically, yeah, encho is right on #2.
There is also probably a bit of fatigue in all the testing of all the different module going through D6 release. Seems like everyone needs testing to get the bugs out and I only have so much time. Just keeping track of the ones I want to watch is keeping me on my toes.
#66
seriously... why are you people subscribing to a closed issue when there's a D6 release available for testing?
This link above is to a head version from 2006.
Is there to be a full 6.0 release of this?
#67
#66 Head tar regenerates every 12 hours so even though head was created in 2006 it has the most current testing version. It the case of my posting it would be.
Last updated: June 24, 2008 - 19:04
Thanks
Robert
#68
flickerfly, the thing is the issue is marked closed that means that there won't be any further activity on here. any further bug fixes will happen in separate issues. so at this point subscribing is just creating noise for everyone else.
#69
i got dopry to create a release for 6.x: http://drupal.org/node/275934 so please stop posting on this issue it's closed for a reason.
#70
@drewish: I understand it's closed; however, it was closed automatically and issues do get re-opened sometimes. The thing is, from my perspective the system is broken and this is the best possible solution which seems to work fine for a number of other contrib modules. If something happens, I want to know. If people subscribing to these things bother you, then please work on one of the issues related to handling notifications in a better way so that it doesn't spam everyone just for a 'sub' message. http://drupal.org/node/34496 I think that would be a great benefit to the community. I note your other contributions including contrib modules. Thank you for that, seriously.
Putting the link to the release on the project page still means I have to come looking at this and a bunch of other module pages in a regular rotation each time I want to find out if I can build a D6 site and promote it to production using this module. That's messed up and wasting community resources looking for things. I'm no coder, but I'd be much happier spending the time trying to figure out how things work and writing documentation than making the rounds yet again.
If there is a better way to get the information I need to come to me, please let me know. I don't like this method either. I've looked and I just can't find anything better.