Download & Extend

youtube url regex fails if there's an underscore in the id

Project:Video Filter
Version:5.x-2.0
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Here's a patch that fixes it. (I don't know what otherspecial youtube also uses in their id, but i guess i now know where to add them now...)

Also,
it would be nice if it failed gracefully if you don't have default dimensions set. The division by zero thing is a bit annoying after upgrading.

AttachmentSize
video_filter.patch409 bytes

Comments

#1

Ok, I guess regular hyphens are used too, so here's a new patch that includes that too.

AttachmentSize
video_filter.patch 410 bytes

#2

This patch works for me, thanks!

#3

Status:needs review» fixed

Fixed in 2.1

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here