When adding its stuff to $closure, the path to preload the supernav images is missing supernav_dir + "search-icon.gif" (see line 1300 in supernav.module), where supernav_dir is the path to the module directory. But the images are located in supernav_dir + '/images'. So this preload attempt results in lots of "Page not found" warnings in Watchdog.

CommentFileSizeAuthor
#4 closure-path.2.patch1.42 KBugerhard
#3 closure-path.patch1.41 KBugerhard

Comments

ugerhard’s picture

ugerhard commented

Argl, sorry, "the path to preload the supernav images is missing" should be "the path to preload the supernav images is".

ugerhard’s picture

ugerhard commented

Another observation: there should probably be a call to base_path() in there as well for installations that are not in a root directory. This affects line 1289 in supernav.module, too, I think: <script type="text/javascript" src="' . drupal_get_path('module','supernav') . '/jquery.shortkeys.js"></script>.

ugerhard’s picture

ugerhard commented
Status: Active » Needs review
StatusFileSize
new closure-path.patch1.41 KB

Here's a patch against the DRUPAL-5 branch.

ugerhard’s picture

ugerhard commented
StatusFileSize
new closure-path.2.patch1.42 KB

Sorry, the patch in #3 only fixes the mssings base_path() calls, but not the 'images/' problem. Here's a new patch.

solutiondrop’s picture

solutiondrop commented

+1
I applied this patch and no longer get the missing image log entries. So far I have not witnessed anything wrong with the patch. Thanks ugerhard.

chrisshattuck’s picture

chrisshattuck commented

Thanks for the patch, ugerhard, and the testing , dividespace. I have applied this patch to the dev in both Drupal 5 and 6.

Thanks!
Chris

chrisshattuck’s picture

chrisshattuck commented
Status: Needs review » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.