In the 5.x version there is an Javascript error (div.appendChild is not a function in line 111 of timeline.js. Reason is the $('timeline-div') is not tranfering correctly to the function.

Please don't ask why....... I really don't know.

The patch attached will solve the problem. Patch against DRUPAL-5 branch, if you want an patch against HEAD, please let me know.

Ithink it was also mentioned in a few other issues, ex. http://drupal.org/node/180484#comment-611006

CommentFileSizeAuthor
timeline-controls-1.patch1.47 KBfranskuipers

Comments

bomarmonk’s picture

bomarmonk commented
Status: Needs review » Needs work

I just tried this patch with the 5.x dev version of timeline and I get the message that "1 out of 1 hunk failed." This fails against the head version as well (I'm using Cygwin and the "patch" command which normally works). Both versions I downloaded as fresh copies from the timeline project (yes, I really had the same experience with the focus patch). Thanks for your work on this module! It's nice to see some progress...

franskuipers’s picture

franskuipers commented
Status: Needs work » Needs review

@bomarmonk: patchfile is alright. you can try it with patch -p0 --binary

jmiccolis’s picture

jmiccolis commented
Status: Needs review » Fixed

franskuipers, thanks for the patch! It has been applied.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.