As noted in the UMN reports, new users can tend to rely on the "Welcome to your new Drupal website!" start screen. Yet the first thing we say to them is "Once logged in.." -- even though ~95% of people reading it for the first time are already logged in as user1 (post-install). Why not check first if they are logged in. If so, we can safely cut that (somewhat confusing) text.

Patch attached. (My first one -- let me know if I did something wrong. Thanks!)

CommentFileSizeAuthor
#5 node.module-detect-if-logged2.patch2.67 KBcrookednumber
module.node-detect-logged-in.patch2.63 KBcrookednumber

Comments

crookednumber’s picture

crookednumber commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented

Good idea!

A couple of things though:

Patch should use tabs, not spaces spaces, not tabs - see http://drupal.org/coding-standards

Also I'd probably check for any logged in user rather than UID 1 - this welcome page will hopefully move to a node and/or the help section during D7, which means it won't disappear as soon as a node is promoted to the front page, so anyone with access will be looking at it, and they'll most likely be logged in too.

kika’s picture

kika commented
Category: feature » task
Status: Needs review » Needs work

I think the start page in D6 needs to go - some of it should be part of installer (and/or optional installer profiles), some of it part of the improved, task-based help system. No need to beat the dead horse. -1

scoutbaker’s picture

scoutbaker commented

I think catch meant to say that patches should use spaces, not tabs, per the coding standards referenced.

crookednumber’s picture

crookednumber commented
StatusFileSize
new node.module-detect-if-logged2.patch2.67 KB

Thanks, Catch. I appreciate the feedback.

New patch attached.

I thought of just testing for a uid>0 but there's no guarantee that a user with uid>1 has "access administration pages", yes? I think it's a good idea, but it seems like the code would have to be pretty granular. Checking user_access("access administration pages"), etc.

Not that I think it's a bad idea. But that Welcome screen (soon to be node?) is really geared toward user1.

sutharsan’s picture

sutharsan commented
Component: node.module » usability

Moving all usability issues to Drupal - component usability.

aspilicious’s picture

aspilicious commented
Component: usability » base system
Status: Needs work » Fixed

No longer an issue

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.