Problem/Motivation

The Vocabulary config entity would need to implement ThirdPartySettingsInterface if we want to allow contrib modules to store module specific metadata to the taxonomy vocabularies.

Proposed resolution

Implement ThirdPartySettingsInterface and ThirdPartySettingsTrait in Vocabulary.

Remaining tasks

Agree approach.
Review patch.

User interface changes

None

API changes

None

CommentFileSizeAuthor
#5 interdiff.txt2.1 KBslashrsm
#5 2331019_5.patch5.34 KBslashrsm
#2 interdiff.txt2.64 KBslashrsm
#2 2331019_2.patch4.57 KBslashrsm
#1 2331019_1.patch1.93 KBslashrsm

Comments

slashrsm’s picture

slashrsm commented
Status: Active » Needs review
StatusFileSize
new 2331019_1.patch1.93 KB
slashrsm’s picture

slashrsm commented
StatusFileSize
new 2331019_2.patch4.57 KB
new interdiff.txt2.64 KB

Added test coverage.

marcingy’s picture

marcingy commented
Status: Needs review » Reviewed & tested by the community

Looks good

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
  1. +++ b/core/modules/taxonomy/src/Tests/VocabularyCrudTest.php
@@ -45,6 +45,8 @@ function testTaxonomyVocabularyDeleteWithTerms() {
+    $this->assertEqual('bar', $vocabulary->getThirdPartySetting('taxonomy_crud', 'foo'), 'Third party settings were added to the vocabulary.');

    Sticking this in a test called testTaxonomyVocabularyDeleteWithTerms() doesn't seem right. 

  2. +++ b/core/modules/taxonomy/tests/modules/taxonomy_crud/taxonomy_crud.module
@@ -0,0 +1,14 @@
+ */
+
+
+/**

    Too many new lines.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new 2331019_5.patch5.34 KB
new interdiff.txt2.1 KB

Fixed.

primsi’s picture

primsi commented
Status: Needs review » Reviewed & tested by the community

Looks fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c560898 and pushed to 8.0.x. Thanks!

  • alexpott committed c560898 on 8.0.x 
    Issue #2331019 by slashrsm: Implement ThirdPartySettingsInterface in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.