This should fix errors reported here http://drupal.org/node/220723
Bug: image_prepare(), a function which no longer exists in image.module, was being called in hook_nodeapi in image_attach. I inspected the method in the D5 version of image.module and replicated its functionality. I moved logic out of the 'prepare' case and into 'validate' and 'insert'/'update' since the 'prepare' case was never called as expected.

Anyhow, this patch will allow image_attach to be fully functional in Drupal 6.

CommentFileSizeAuthor
#11 drupal6_node_attach_no_static.patch3.89 KBnetaustin
drupal6_node_attach.patch2.9 KBnetaustin

Comments

drewish’s picture

drewish commented

i'm not sure about the static $image. shouldn't that data be passed through the node object?

netaustin’s picture

netaustin commented

I didn't think so... wouldn't the node object be the node which we are trying to attach an image to? $image is a node of its own which we need to initialize in validate, to check for errors, and then save in insert/update.

xerexes’s picture

xerexes commented

subscribing

coltrane’s picture

coltrane
he/him
commented

Not sure yet about the use of a static but as for testing the patch applies cleanly and images can be attached without errors.

drewish’s picture

drewish commented

marked http://drupal.org/node/220723 as a duplicate

ansorg’s picture

ansorg commented

applied the patch to a "Image 6.x-1.x-dev (2008-Mar-03)" module in my drupal-6.1 and seems to work, upload from a page edit does work. No sideeffects so far

thanks
Jens

xerexes’s picture

xerexes commented

Just curious - any reason this hasn't gotten added to a release yet?

NuZeilen’s picture

NuZeilen commented

I just always do something wrong, can someone upload the image_attach.module file that is already patched?

Thx,
Gorik.

jhendow’s picture

jhendow commented

Has anyone uploaded a patched file? I'm a windows user and having a miserable time trying to get it to patch correctly.

drewish’s picture

drewish commented
Status: Needs review » Needs work

i'm pretty against the static variable. i think those values should be passed through the forms api.

netaustin’s picture

netaustin commented
StatusFileSize
new drupal6_node_attach_no_static.patch3.89 KB

drewish, It seems like there are two ways to get the image node from validate to insert/update intact... 1) static variable, 2) attach the image node to the parent node (I used $node->attached_image)

Anyways, I posted a new patch using the second method; no static $image anymore. Let me know if anything else has to happen to get this working for you.

0000@drupalchina.org’s picture

0000@drupalchina.org commented

Sorry but the patch drupal6_node_attach_no_static.patch didn't work for me, mine is 6.x-1.x-dev (2008-4-01)

I tried drupal6_node_attach.patch and this works, both thanks, I got this problem for a very long time, (since the 6.0 released -_- )

drewish’s picture

drewish commented
Status: Needs work » Needs review

marked #243655: Can't upload new image when creating a post. as a duplicate

dvdbosch’s picture

dvdbosch commented

How do i install this patch?

mrgoltra’s picture

mrgoltra commented

subscribing

dvdbosch’s picture

dvdbosch commented

Thanks,

And where can i do that? Sorry for the newbisch question.

coltrane’s picture

coltrane
he/him
commented

dvdbosch, http://drupal.org/patch has an overview of patches with information on applying. If you have other questions drupal.org/support and searching often have the answers.

drewish’s picture

drewish commented

marked #247457: Image Attach isn't attaching as a patch

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Needs review » Needs work

The patch on #11 did not fix it for me.

CNlQ8o’s picture

CNlQ8o commented

subscribing

bneijt’s picture

bneijt commented

It might be better to just drop the current buggy attach and work on a multiple-attach like in this bug: http://drupal.org/node/81102
So anybody who codes on this, consider looking into that other bug.

Hetta’s picture

Hetta commented

marked http://drupal.org/node/261900 as duplicate - there, they said that netaustin's patch at the top fixed things, not the patch in #11.

audiomason’s picture

audiomason commented

applied patch. improved but still glitchy.

image attach fails when story is previewed before save.

drewish’s picture

drewish commented

marked #265658: image doesn't attach to story or page node as a duplicate

drewish’s picture

drewish commented

marked #265791: image will not attach as a duplicate

nicksergeant’s picture

nicksergeant commented

Subscribing.

vladimir.dolgopolov’s picture

vladimir.dolgopolov commented

See:
Tests for Image Attach module

The 'static' patch works, the 'no static' one fails the test.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Closed (duplicate)

Patch no longer applies. Also, I think most of the patch's intent is covered in #81102: Attach Multiple Images with image_attach using Drupal upload mechanism already, and the title of this issue is most probably the cause for why this issue never had the attention it deserves. Hence, marking as duplicate.