Allow shorter periods for IP bans [#233180]

A task for future development would be to extend the current form that allows for setting an expiration on an IP ban to include time periods shorter than a day.

Some possibilities:

- Ban for X hours
- Ban for X days
- Ban for X weeks (days * 7)
- Ban for X months (days * 30)

Comment	File	Size	Author
#4	troll_expire_granularity_to_minutes_default_to_endofday_233180_4.patch	5.46 KB	bibo
#3	troll_expire_granularity_to_minutes_233180_1.patch	5.11 KB	bibo

Comments

Comment #1

jaydub commented 1 April 2008 at 06:06

Assigned:

Unassigned

» jaydub

Comment #2

pomliane commented 3 February 2013 at 20:05

Status:

Active

» Closed (won't fix)

This version of Troll is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.

Comment #3

bibo commented 17 November 2015 at 15:51

Version:	5.x-1.x-dev	» 7.x-1.x-dev
Assigned:	jaydub	» Unassigned
Issue summary:	View changes
Status:	Closed (won't fix)	» Needs review

Status	File	Size
new	troll_expire_granularity_to_minutes_233180_1.patch	5.11 KB

I needed also the feature for more finetuned IP bans, so I created this relatively simple patch that adds there changes:
- IP ban form insert/update now handles minutes & hours as well as the day.
- The default timestamp is now +3600s to current time.
- Expire time is now on by default (avoiding totally useless and endless IP bans).
- IP bans shown on the table show the correct granularity (per minute, not per day)

My patch also contains a few lines fixing critical bugs in these issues:
#2616066: Troll lets Varnish cache the redirects, making ANY user see blocked.html!
#2473413: Ip banning doesnt work(!) -> oneliner fix