The SQL for PostgreSQL is missing in *.install file.

CommentFileSizeAuthor
#2 submenutree-5.x-0.4-pg-1.tar_.gz11.79 KBbengtan

Comments

bengtan’s picture

bengtan commented

Hi,

Yes. PostgreSQL is unsupported in 5.x-0.4 and previous, because ...

I haven't had any reason to use Postgres,
I didn't go to the trouble of setting up a Postgres server, and
I'd rather the submenutree.module fail fatally and noisily for Postgres than put in code that hasn't been tested.

If you know PostgreSQL, you're very welcome to provide a patch. It's only just the table creation part of .install, like you say.

Else, if you're happy to test for me, I can work on it, but probably tomorrow at the earliest (it's nighttime now as I write this).

bengtan’s picture

bengtan commented
StatusFileSize
new submenutree-5.x-0.4-pg-1.tar_.gz11.79 KB

Here, try this quick change. You may have to totally uninstall and reinstall the module.

Also, I'm coding PostgreSQL (and blind) for the first time, so it might take a couple of tries to get it right.

bengtan’s picture

bengtan commented
Assigned: Unassigned » bengtan
Status: Active » Needs review
peterdd’s picture

peterdd commented
Assigned: bengtan » Unassigned
Status: Needs review » Active

I personally have no urgent need.

There is no (warning) statement that this module isn't compatible to Drupal 5 "sold features".
The download tells "Recommended for 5.x" but there is/was no PostgreSQL support.

Maybe I missed it or Drupal hasn't a automated test environment where people can see reports what modules work for different environments and what not. The reports could be a table like this:

---------------------------------------------------------------
test system          | linux 2.bla          | linux 2.bla       |....
                     | mysql 4.bla MyISAM   | postgres 8.bla|
                     | php 5.bla, ....      | php 5.bla, ...   |
------------------------------------------------------------------------- 
drupal core(version)| ok (green)            |  ok (green)   |
module1 (version)   | 6/10 (6 tests passed  |  10/10 (green)|
                    | 4 non critical issues)|                |
module2 (version)   | - (broken)             |  - (broken)   |
module3 (version)   | 7/7 (green)            | 7/7 (green)   |
-----------------------------------------------------------------------

This table is probably an oversimplifation, I know.

The table could contain links to the module test results. This could help developers to know about problems they can't easily test/reproduce themselves.

bengtan’s picture

bengtan commented

I think you'll have to address this issue to the drupal.org infrastructure or drupal.org webmasters.

AFAIK, the download system marks submenutree.module as "recommended" only because it's an official release rather than a development snapshot. I'm not aware of any capability or functional requirements.

I certainly didn't mark it as recommended - drupal.org did that itself.

As a related issue, when this module gets ported to Drupal 6.x, it should support Postgres automatically, because that's done by the D6 database abstraction layer.

bengtan’s picture

bengtan commented
Status: Active » Closed (works as designed)

Closed due to lack of further feedback.