Drupal 6?

It will. Just question of time

Any progress?

Any followup on this? I'll take a stab at it, but don't want to re-create work that may have already been done.

I'm happy to do bugtesting (and maybe bugfixing, though I don't know if my coding skills are up to snuff) to help this along.

OK, so I ran this through Deadwood and did a little cleanup using Coder. Don't think this resulted in a working module -- it didn't. While the module does show up in the module list, you can enable it, and you can add phone fields to a content type, these fields won't show up in the content-creation or editing pages. But I'm hopeful this might have gotten us a little closer.

I left all of the notes Deadwood inserted in the files as comments at the top.

Hi all,

attached is a version that works on D6.

the 'validate' in phone_widget has been moved to phone_field 'validate'
the 'process form values' in phone_widget has been moved to to phone_field 'presave'

phone_widget is now same as text_widget

I also added the fix for http://drupal.org/node/275860

How about adding this for token support?

/**
 * Implementation of hook token_list
 */
function phone_token_list($type = 'all') {
  if ($type == 'field' || $type == 'all') {
    $tokens['phone']['raw']       = t('Raw phone numbers');
    $tokens['phone']['formatted'] = t('Formatted phone numbers');
    return $tokens;
  }
}

/**
 * Implementation of hook token_values
 */
function phone_token_values($type, $object = NULL, $options = array()) {
  if ($type == 'field') {
    $item = $object[0];
    $tokens['raw']       = $item['phone'];
    $tokens['formatted'] = $item['view'];
    return $tokens;
  }
}

I use this on a few sites that I maintain. Could the maintainer roll a dev release of this to facilitate further community testing?

rolled a patch against cvs HEAD checkout; attached.

Hi there

It looks as if good progress is being made for this module. Any idea when it will be finally ported for general release?

Thanks

It seems like the first step would be rolling the official development release so the community can begin widely testing, but that's up to the maintainer. There does seem to be enough to create that release, though.

hi Bob,
I tried to patch HEAD, but some of the hunks failed. Here are my results:

patch < phone-6.x-update.patch
patching file phone.info
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file phone.info.rej
patching file phone.module
Hunk #1 FAILED at 7.
Hunk #2 succeeded at 118 (offset -4 lines).
Hunk #3 succeeded at 182 (offset -26 lines).
Hunk #4 succeeded at 294 (offset -26 lines).
Hunk #5 FAILED at 375.
Hunk #6 succeeded at 417 with fuzz 2 (offset -34 lines).
Hunk #7 FAILED at 442.
Hunk #8 FAILED at 482.
Hunk #9 succeeded at 663 (offset -84 lines).
4 out of 9 hunks FAILED -- saving rejects to file phone.module.rej

Attaching my rej files, in case that's helpful.
Cheers -
Scott

+1

I have started to use the module from post #6. If the author of this module would be so kind as to check in a version for Drupal 6 as a dev module it would be very helpful to those of us that need this functionality. So far so good - the module seems to work just fine with my Drupal 6.4 release.

I'd also like to add SIP URL dialing for softphone support.

Since the last patch didn't work yet, I tried the D6 port in #6.

malaussene, a few things so far...

* field sort order is not respected (in 'manage fields', I can drag the phone field to the desired place in the sort order, but when I save the Phone field skips back up to the top.
* First time I added a phone number, it did not save the data. I had to edit the node again and re-add the number, in order to save. Can not seem to track it down yet, but thought I;d mention it here just in case.

Otherwise, looks good :)

scottrigby,

I was not able to reproduce the issues you describe on my install
which might be a little bit old now (Drupal 6.3 and CCK 6.x-2.0-rc4)

What Drupal version do you use?
And what is your CCK version?

Are you able to reproduce it when just Drupal core, CCK and Phone modules are enabled?

Subscribing.

I'll test it too if there is a dev branch started. :) thanks!

malaussene - 'pologies for the late response (2 weeks ago)...

I also tested with current versions of 6.x core (6.5 & 6.6) and with cck 6.x-2.0-rc10.

* The cck sort order is fine now.

* However, the phone number not saving data is still happening.
But what I think is going on is validation. If I add an actual phone number, it shows up fine. But if I add a bogus phone number, like 1 (215) 1234567, I get a blank result that follows my phone display format such as 1 () - (displaying country code plus area code in brackets, but no phone number).

I think the validation should display a friendly message on the edit form instead like "this does not appear to be a valid US or Canadian phone number - please enter a valid number" etc.

:)
Scott

But if I add a bogus phone number, like 1 (215) 1234567, I get a blank result that follows my phone display format such as 1 () - (displaying country code plus area code in brackets, but no phone number).

I can verify the module from number 6 does this.

Another thing I've noticed is that it does not show up in views 2.

subscribing

can someone please integrate germany ?

Hi Scott,

the saving data issue seems to affect also the module for Drupal 5.

Here is a patch, but could you open a separate issue for this ?

thanks

Hello Babalu,

could you please open a separate issue.

thanks

Hello that0n3guy,

can you elaborate a little bit more on the no show on views2 ?
It seems to work fine on my test server with cck-6.x-2.0-rc10 and views-6.x-2.1

Kenan

Malaussene,

I went back and double checked my views and noticed there was a lot more missing then just the phone stuff. I disabled views, uninstalled it, and re-enabled it and it seems to work now.

Sorry for crying wolf :).

Peter

Hi guys

Any idea when this new module could be available for dev release? I may not be able to code (yet) but happy to test if that is of any help

Thanks

Subscribe.

Looks like the module maintainer hasn't been active at drupal.org since July...

Subscribing.

I will try fo find time in the next weeks to commit a new release

Could you create a separate issue for the issue (integrate germany)

Subscribing

@malaussene: re #22 ^^ yesterday I opened a separate issue: #333852: Phone not saving data

+1

Please please please please create a dev release so we can work on this. We don't need a full release yet and there are several people (above) willing to do the work and test, but there's a limited amount we can actually do without a dev release. I'm sure you're busy but once we have this key step completed you will have the community able to do a lot of work for you.

Just added a first 6.x release

Fantastic! Thanks thierry_gd :)

Great - thanks for all your hard work guys. Will be uploading tonight

Awesome! Thanks!