This module is great and much more reliable than making sure my clients set an external style to their links. I have some clients, though, who have multiple servers making up their site and I would like to have it so it didn't open up links to those other servers in new windows. Is there a way to add an exclusion list, or define multiple "internal" domain names?

CommentFileSizeAuthor
#3 elf.module_n233517_rev3.patch2.52 KBdamienmckenna
#2 elf.module_n233517_fixed.patch2.49 KBdamienmckenna
#1 elf.module_n233517.patch2.49 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new elf.module_n233517.patch2.49 KB

I've attached a patch that provides a new settings text box where you can enter a comma separated list of additional hostnames / URLs that should be considered internal, i.e. the configured external stylings will not be applied. This is simple saved as a variable so you could store it in your settings.php file if needed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new elf.module_n233517_fixed.patch2.49 KB

Egg on my face. The first patch had a silly typo. Here's the fixed patch.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new elf.module_n233517_rev3.patch2.52 KB

Ok, third time's a charm... Accidentally used a hook to name a local function.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Postponed
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Version: 5.x-2.0 » 5.x-3.x-dev
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Postponed » Active
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: Unassigned » xano
Status: Active » Fixed

Added and committed.

The admin panel now features a textarea where site administrators may define sites that are considered 'internal'. The future D6 version will consider domain fallbacks for Locale as internal sites as well, so these will not have to be entered manually.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thanks for adding this :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned