Hello,

The Modrst is a very simple module. During development, It can be used to:

  • To reinstall and to enable the module, you only need click the "restart" link.
  • To enable the module directly, by the "start" link.

Project page:Modrst
Git: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/colorsand/2335977.git modrst

Comments

gaurav.pahuja’s picture

gaurav.pahuja commented

I tried to enable this module on vanilla Drupal installation and getting Fatal error:

Fatal error: Call to undefined function module_filter_new_modules() in D:\xampp\htdocs\drupal\sites\all\modules\modrst\modrst.module on line 163

It seems this module has dependency on 'Module Filter' module.

gaurav.pahuja’s picture

gaurav.pahuja commented
Status: Needs review » Needs work
gaurav.pahuja’s picture

gaurav.pahuja commented

Automated Review

A lot of issues identified by pareview.sh. Please look into these issues.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements
3rd party code
Yes: Follows the guidelines for 3rd party code.
README.txt/README.md(*)
No(*). No readme file found.: Follows the guidelines for in-project documentation and the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Not able to identify this due to blocker issue.
Coding style & Drupal API usage
  1. (*) Fatal error while enabling this module. Seems this module has dependency on some other module but that is not mentioned in info file. Unable to test your functionality.
  2. hook_help is missing in your module.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

colorsand’s picture

colorsand commented

Hi gaurav.pahuja,
Thanks for reviewing it.
I has been added the README.txt and implemented the hook_help.
I has tested this module after uninstall the module filter module，and did not get the fatal error. I has been delete some code in order to be compatible with module_filter module .

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
commented

Hello @colorsand

The project description is not very clear.

  • What do you mean by direct start?
  • How does your project differ from Devel?
colorsand’s picture

colorsand commented

Thank you pingwin4eg

for example, hook_schema is called at install and uninstall time, so you update or modify hook_schema() while your module is enabled, you must to get around this:
1. disable the module
2. uninstall the module (via the modules page)
3. enable the module

We might need to run these steps multiple times in the development process. I am not sure whether Devel can simplify the operation, Modrst is the module to completed these 3 steps by "restart" link.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.