Hi David, contributors..

First of all, thank you for an amazing module. It came at a time that I was in despair over the views filtering and search modules not providing me with an intelligent and intuitive interface.

Faceted Search is AWESOME! And not only that, it's well documented, the Readme.txt would probably win #1 prize in a "Best Module Readme File" competition. The code is also very well documented, congrats guys! :)

Anyway I found an issue where updating the terms of a node with a hierarchical vocab would not update the facets on the faceted search page, but changes to the terms from a flat vocab do appear.

I see in the code and from the issue http://drupal.org/node/230675 that this is by design, and I should just call _taxonomy_facets_update manually, but the question I have is why does it work for flat vocabs automatically but not for hierarchical ones?

Thanks again
Mark

Comments

David Lesieur’s picture

David Lesieur commented

Glad you like the module! (and its documentation!)

Associations to terms from flat vocabularies are immediately effective in the Guided search because in this case the core term_node table is used, and that table is always updated immediately upon saving a node. Associations to terms from hierarchical vocabularies, on the other hand, are looked up in a table that's specific to the Taxonomy Facets module, and that table is only updated on cron runs (its data is derived from the term_node table).

Many people get confused by this, so perhaps Taxonomy Facet's table should also be updated upon saving a node... However, updates on cron will still be needed to account for changes in the vocabularies or the terms themselves, which usually affect many node term associations at a time.

Mark Theunissen’s picture

Mark Theunissen commented
Status: Active » Closed (fixed)

Ok thanks for the explanation. I have implemented a nodeapi() hook to act on inserts and updates, so all is good!

David Lesieur’s picture

David Lesieur commented
Title: Updating manually the node-term references for hierarchical vocabulary » Update node-term associations immediately upon node insert/update
Version: 5.x-0.20 » 6.x-1.x-dev
Category: support » feature
Status: Closed (fixed) » Active

Actually, I had pulled this out because of problems with free tags. However, I'm just realizing that it is safe to assume that taxonomy_nodeapi() would always be called before taxonomy_facets_nodeapi() because of their respective module names. This means that the term_node table is already up-to-date when taxonomy_facets_nodeapi() gets called and that it would be safe to call _taxonomy_facets_update() from there.

It would be a good idea to improve taxonomy_facets_nodeapi() with all this in mind.

Wanna provide a patch so this becomes part of the next release? ;)

Mark Theunissen’s picture

Mark Theunissen commented

Sure thing, will work it out later.

Mark Theunissen’s picture

Mark Theunissen commented

Should we drop the taxonomy_facets_node table?

If so, we need an upgrade path, so I was thinking of doing the following which should provide one:

  • write a new update function taxonomy_facets_update_5() that iterates through every record in the table taxonomy_facets_node and calls _taxonomy_facets_update() on those that are changed (much like one big taxonomy_facets_cron call)
  • drop the taxonomy_facets_node table
  • alter the nodeapi function to do updates immediately
  • remove the taxonomy_facets_cron hook
  • alter _taxonomy_facets_touch() to perform updates immediately
  • change the taxonomy_facets_rebuild() function to update immediately, instead of next cron run

Is this what you'd prefer? Or leave the table alone and just do the updates in nodeapi() without changing any records?

David Lesieur’s picture

David Lesieur commented

Actually we still need to support cron, because vocabulary changes may affect lots of nodes and we don't want to do such costly updates in one go. For example, changing a term's parent term affects all nodes associated to children of the modified term — all entries of taxonomy_facets_term_node related to those children need to be updated (actually, it is not managed that way since the table is updated in a per-node basis).

To sum it up, the cron stuff and the taxonomy_facets_node table are still needed. We only need taxonomy_facets_nodeapi() to call _taxonomy_facets_update() immediately when a node is created or updated.

David Lesieur’s picture

David Lesieur commented
Component: Code » Taxonomy Facets
Status: Active » Fixed

I've just committed changes to the module to do this.

Mark Theunissen’s picture

Mark Theunissen commented

Aaaarrrgghh I completely forgot about this.... sorry!

Drupal.org needs the ability to "star" threads in the tracker so they don't get lost once they become read!

Apologies. I know it wasn't a big change but I meant to do it.

David Lesieur’s picture

David Lesieur commented

No problem!

There are plenty of issues left, if you feel an itch for coding. :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.