I recently had a problem with an Administration Theme on a site I'm working on and I have traced the issue to jRating. This issue has been reported before in the forums (http://drupal.org/node/64409 comments 15 and 16), but I didn't see anything about it in the jRating issue queue so I thought I'd post it here.

The issue is that when a separate Administration Theme is used and jRating is enabled, the

drupal_add_js('function rating_postsubmit(nid){' . theme('jrating_postsubmit') . '}', 'inline');

call in jrating_menu causes an issue on the admin/build/block page where it causes the Administration Theme to be displayed instead of the site theme. The admin/build/block page is a little different than the rest of the admin area, where it should ignore the Administration Theme in order to allow the user to place blocks in the proper content areas.

I made a temporary fix by changing the drupal_add_js line to:

drupal_add_js('function rating_postsubmit(nid){return true;}', 'inline');

What is the point of theme_jrating_postsubmit? Under what circumstances would a user re-theme it to be anything other than "return true;"?

I'm trying to figure out what the best way to fix this is. I suppose that we can check the args for "admin/build/block", but that seems a little too specific...

Thanks in advance,
-mike

Comments

hickory’s picture

Status: Active » Closed (duplicate)

http://drupal.org/node/125787

Fixed in the dev version a while ago.

ultimike’s picture

Sweet - thanks for the info.

-mike