This patch uses a blank div to allow block level ellements (like input> to go inside the form element per xhtml 1.0 specs. This patch works and validates, and is required for validation.

Robin

CommentFileSizeAuthor
#5 empty__div_form__item_fix.patch5.06 KBrobin monks
#3 empty div form item fix_0.patch5.06 KBrobin monks
empty div form item fix.patch682 bytesrobin monks

Comments

dries’s picture

dries commented

Yes/no? Please advise. If this patch is required, we might want to revise the call sites of form(). I believe some are adding divs to solve exactly this.

robin monks’s picture

robin monks commented

You're right, some calls are using <div class="container-inline"> to do this. I'll find these instances and correct them, and then attach a new patch for this.

Robin

robin monks’s picture

robin monks commented
StatusFileSize
new empty div form item fix_0.patch5.06 KB

Here is the new patch, which also removes unneeded (AFAIK) <div>'s from form's.

Robin

Stefan Nagtegaal’s picture

Stefan Nagtegaal commented

Could you please remove the spaces from your patch name? they break the link in e-mail clients quite often.. I would prefer not to use spaces at all inside patch filenames at all, I would encourage you to use something like 'patch_name.patch'..

Stefan

robin monks’s picture

robin monks commented
StatusFileSize
new empty__div_form__item_fix.patch5.06 KB

Oh bother...

Robin

dries’s picture

dries commented

You can't remove container-inlines; these ensure that the form elements are displayed as display: inline. Removing container-inlines breaks those forms!

Steven’s picture

Steven commented

Applied to HEAD. I checked and couldn't see any redundant divs. They are all either for container-inline or for use in themes.

Anonymous’s picture

(not verified) commented