theme function bypassed for theme_calendar_links() and theme_calendar_date_combo()

jscheel - March 13, 2008 - 21:29
Project:Calendar
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

theme_calendar_links() is called directly in a few places, preventing overrides in template.php. Patch coming in a minute.

#1

jscheel - March 13, 2008 - 21:31
Status:active» patch (code needs review)

Ok, patch is attached.

AttachmentSize
calendar_issue_233975.patch2.33 KB

#2

JohnAlbin - April 5, 2008 - 22:01
Title:theme_calendar_links() called directly» theme function bypassed for theme_calendar_links() and theme_calendar_date_combo()
Version:5.x-2.0-rc» 5.x-2.x-dev
Priority:normal» critical

Jared, your patch was almost RTBC, but you missed one hard-coded theme_* instance: theme_calendar_date_combo() is called directly in calendar_ical.module.

AttachmentSize
theme-bypassed.patch3.17 KB

#3

jscheel - April 8, 2008 - 18:30

Ah cool, thanks for fixing that!

#4

KarenS - April 13, 2008 - 11:13

Thanks for the patch and I apologize for not getting to it right away. I am fixing a computer melt-down that finally resulted in starting all over with a new computer and will come back and review this once I'm functional again.

If anyone else has reviewed the patch, please jump in and indicate whether it seems to work and I'll prioritize these patches first when I'm back in commission.

#5

KarenS - April 22, 2008 - 22:00
Status:patch (code needs review)» fixed

Fixed in latest commit. Thanks!

#6

Anonymous (not verified) - May 6, 2008 - 22:02
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.