Missing period in secondary links description

David_Rothstein - March 14, 2008 - 02:29
Project:Drupal
Version:6.x-dev
Component:menu system
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed
Description

This was driving me crazy ;) ;)

AttachmentSize
secondary_links_description.patch2.55 KB

#1

keith.smith - March 14, 2008 - 02:40
Status:patch (code needs review)» patch (reviewed & tested by the community)

Good catch.

#2

Dries - March 14, 2008 - 08:53
Version:7.x-dev» 6.x-dev

Ah! Things like this drive me nuts too. I've committed this to CVS HEAD. I'm moving this down to DRUPAL-6 for Gabor to review. Not sure he'll want to break translations to fix this. I leave that up to Gabor to decide.

#3

Gábor Hojtsy - March 21, 2008 - 22:04
Version:6.x-dev» 7.x-dev
Status:patch (reviewed & tested by the community)» fixed

I think a missing dot is better not to warrant breaking translations here, I think it is subtle enough to not be an issue if we leave it as-is in Drupal 6. Not committed to Drupal 6.

#4

David_Rothstein - March 28, 2008 - 03:53
Version:7.x-dev» 6.x-dev
Status:fixed» patch (reviewed & tested by the community)

Just to be really nitpicky.... the part of the patch that fixes the update function could still go into 6.x, I think. (Text that gets inserted during the Drupal 5->6 upgrade is never translated, right?) So people upgrading from Drupal 5 would get the fix, but fresh installations of Drupal 6 would have to do without the precious period ;)

Patch is attached.

AttachmentSize
secondary_links_description_6.x.patch939 bytes

#5

Gábor Hojtsy - April 25, 2008 - 21:26
Status:patch (reviewed & tested by the community)» fixed

Some people are judging Drupal 6's quality by the patches we "need" to apply between point releases. I am trying to mark these kind of fixes as "(very minor)", so to avoid us looking like having a buggy version (which we don't have). So all this said, I'd love if we could concentrate on fixing any important bugs, and not missing dots. Committed this one to Drupal 6.

#6

Anonymous (not verified) - May 9, 2008 - 21:31
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.