Closed (fixed)
Project:
FeedAPI
Version:
5.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
14 Mar 2008 at 12:03 UTC
Updated:
29 Mar 2008 at 10:52 UTC
If gethostbyname is passed an IP address to start with it returns the IP address so:-
$url_parts = parse_url(is_string($args[1]) ? $args[1] : $args[1]->url);
$op = (gethostbyname($url_parts['host']) !== $url_parts['host']) ? $op : FALSE;
evaluates false and $op gets clobbered when it maybe valid. Would drupal's valid_url() not be better or does simpleapi accept other schema?
Tagged priority minor as - OK, I only noticed this because DNS happened not to be working with apache at a moment. It wasn't obvious what the error was either (sending it to simplepie and logging/displaying the error - curl dns lookup - would have been easier to debug). I'm guessing IPs in url's are not so common - but they are valid.
Comments
Comment #1
aron novakThanks for the report, now it's fixed. The next daily dev package will contain the fix.
Comment #2
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.