This upgrades the base module only, rest is untouched. Nevertheless, it may be used as a temporary solution if you just need a simple map.

Just needed a quick fix really, however going through all these 81 points took a couple of hours, so I though I'll share this anyway, at least you can use it as a reference what's to be updated.

Changes:
- new syntax in gmap_menu (see point 1)
- implemented gmap_theme hook for registering all theme_* things (18)
- updated cache_set and cache_get calls (28 & 29)
- changed url() arguments in one case (7)
- changed Drupal.extend to jQuery.extend (60)
- added core=6.x to the gmap.info file :)

CommentFileSizeAuthor
#4 gmap.to_.drupal6_1.patch27.54 KBDenRaf
#2 gmap.to_.drupal6_0.patch26.3 KBDenRaf
partial_upgrade_to_6.x.diff4.59 KBwrwrwr

Comments

convexk’s picture

convexk commented

Hi,

first thanks for the great and useful work.

Does the patch work for you, i.e. are you able to enable the GMap basic module in 6.1 distribution.
I am still getting the base module as "version incompatible" by my 6.1 distribution.

Btw does anybody have more information on how drupal 6.1 checks for version compatibility of uploaded modules?
That would serve as a good start for finding incompatibilities. Taking this one step further, even output to the user
the code parts that have been found incompatible.

DenRaf’s picture

DenRaf commented
StatusFileSize
new gmap.to_.drupal6_0.patch26.3 KB

I did a bit further on the diff. There is still a problem with displaying the map itself. So any help is more then welcome.

pobster’s picture

pobster commented

It's probably not displaying because you haven't created entries in hook_theme for all the theme calls? I only see one for 'gmap_marker_popup', there's plenty more than that! Also the one you have got in that hook seems to have a stray bracket in it? 'gmap_marker_popup('??!!!

Incidentally the gmap settings form wouldn't submit until I removed the $form, &$form_state from the function declaration; they're not required here anyway as the form magic is supplied by drupal_get_form in hook_menu.

Pobster

DenRaf’s picture

DenRaf commented
StatusFileSize
new gmap.to_.drupal6_1.patch27.54 KB

With this new patch, you can see the map. The problem is now that it doesn't calculate it's position.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

...

romipoison’s picture

romipoison commented

how to apply patch?

chadd’s picture

chadd commented

also wondering how to apply patch?

axyjo’s picture

axyjo commented

Sweet. I was googling for hours until a simple drupal site search gave me this. Can I add patches if I find any more bugs?

Thanks.

gellpak’s picture

gellpak commented

subsub

thechraveler’s picture

thechraveler commented

subscribe

Anonymous’s picture

Anonymous (not verified) commented

Subscribing

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

To those who want to see this ported faster, there is information about the current state of things, as well as what you can do to help, at The State of Geospatial in Drupal. Hope to see some of your patches, documentation, and reviews. :)

encho’s picture

encho commented

subscribing

Anjaro’s picture

Anjaro commented

subscribing...

jasontanner’s picture

jasontanner commented

subscribing

zhte’s picture

zhte commented

subscribing

zmove’s picture

zmove commented

Hi,

Is there a way to get a full D6 package, because the module evolved between the patches and I'm afraid to apply patch by hands and see errors cause the patch apply on a old version. (yes, I patch by hands because patching on windows sux, in fact, patching in command line sux...) ^^

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

subscribing

dan_aka_jack’s picture

dan_aka_jack commented

subscribing...

bdragon’s picture

bdragon commented
Status: Needs work » Fixed

Drupal 6 is equally supported and in sync with Drupal 5 development now.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.