Download & Extend

an image node created by mailsave_to_image_attach module is not published by default

Project:Mailsave
Version:5.x-3.1
Component:Miscellaneous
Category:support request
Priority:normal
Assigned:Stuart Greenfield
Status:closed (fixed)

Issue Summary

Thank you for the great module.

An image node created by mailsave_to_image_attach module seems not to be published by default. I have to edit and publish the image node by hand everytime I send an image. I want the image published immediately without editing it. How can I do it?

Thanks

Comments

#1

Assigned to:Anonymous» Stuart Greenfield
Status:active» needs review

This happens because the way mailsave_to_image_attach was written it didn't assign whether the node should be published or not, and so it ends up not published - my error :-)

I have changed it so that it now respects the configured preferences for image nodes, including the settings for "sticky" and "promote".

The one difference is that if mailhandler specifically sets the node being generated to be not published then mailsave_to_image_attach will follow THAT setting. I think that's the right behaviour - if you don't want the message to be published then you presumably don't want the attached images to be either. Equally, if you force the node to be published (via mailhandler) then the image will also be published.

If mailhandler doesn't provide a "preference" then the regular setting for image nodes will be used.

I tested it quickly here and it seems to work ok, with images publishing (or not!) as I think they should.

Let me know if the patch works ok for you, and if it does I'll commit it to the next mailsave release.

Thanks!

AttachmentSize
mailsave_to_image_attach_publish_settings.patch 2.14 KB

#2

It works fine also in my site. It respects the configured preferences for image nodes except when mailhandler's "status" command is set 0.

Thanks!

#3

Status:needs review» fixed

Thanks for testing so quickly and feeding back the results. I have just committed a new version of mailsave that incorporates this fix. The package (5.x-3.2) should be available shortly.

#4

GREAT. Thanks to the patch, I can introduce a new mobile feature to my site. Thanks again!

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.