Closed (fixed)
Project:
Taxonomy Menu
Version:
5.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Mar 2008 at 10:09 UTC
Updated:
14 Dec 2009 at 16:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
lemonis commentedI have a similar problem. But I think its not only the vid.
I can access every term in two ways:
taxonomy/term/31
taxonomy/vocabulary/4/70
4 ist the vid
31 and 70 is the same term
The taxonomy menu is using the later url with the vid.
And pathauto generates an alias for the first.
Is there a way to adapt taxonomy menu to use the first way?
Comment #2
murzPatch for DRUPAL-5 CVS: remove link to main module page in paths.
This patch add an option in module settings to remove main page link from menu and adds all vocabularies to menu root.
Path from:
category/1/2/3
category/5/8
converts to:
1/2/3
5/8
Comment #3
murzAdded support pathauto module for building SEF aliases.
Now you can convert path from
category/1/2/3to
and more other variants with pathauto and token templates.
Comment #4
giggler commentedCool - what setting do you need to change to have the following. I ran the patch and the menu is still category/1/2/. Is it changing pathauto to [catalias]?:
category/1/2/3
to
category/fruit/apples/red
Comment #5
giggler commentedNevermind...it was [catpath-raw] ! Thank you so much, now it works perfectly!
Comment #6
lemonis commentedHm, the patch isn't working for me. The "Hide link to module page" checkbox was added but if I select and save it, its unchecked again (after saving/reload).
I have 5.7 not the CVS Version.
Did I miss a step?
-> patch module
-> update.php
-> activate "Hide link to module page" checkbox
Comment #7
murzI test this patch in my Drupal 5.7 and "Hide link to module page" checkbox stored successfully. I have edited some places in my patch, try the new version.
Comment #8
murzNew patch version with solved issue when using Page Title version 5.x-2.0-alpha5.
Comment #9
murzComment #10
tf5_bassist commentedMaybe it's just me, but I'm not finding anywhere how to apply patches without having ssh access. Is there another way to apply this patch?
Comment #11
hutch commentedYou can apply patches on a Linux or a Mac box, or at a pinch use a Linux LiveCD such as Knoppix. I don't know wether the patch program is available for Windows but Cygwin might do it.
Comment #12
murzYou can download module files to local folder on your computer, apply patch (with the software or with hands), and after that upload pached version of module to site via FTP or any other method.
Comment #13
ckngConfirm patch works as stated.
Thanks for the patch =)
Comment #14
nbchip commentedFor applaying patches i use Zend for Eclipse...
Patch works but unlike pathauto u can only make one path for all vocabularies...
Now if only i could somehow make Taxonomy Breadcrumb to work with Categories or maybe Custom Breadcrumbs (but they unfortunetly dont have settings for vocabularies)...
but ill see what will happen when i put custom tpl pages with views behind categories links...
Comment #15
suit4 commentedJust tried taxonomy_menu_hide_modulepage_w_pathauto_4.patch and id did not work for me as expected.
vocabs and terms are replaced nicely and correctly, but links from the seconf menu level do not show up in the selected view.
I use taxonomies with 2 levels or deeper.
parent - shows up in correct view
- Child - shows up in stadard node view.
Proof me wrong, but there are two lines in the patch which seem to be wrong:
Line 76 should read: + if ($vid=variable_get('taxonomy_menu_hide_module_page', FALSE)?arg(0):arg(1)) {
Line 82 sould read: if ($tid=variable_get('taxonomy_menu_hide_module_page', FALSE)?arg(1):arg(2)) {
(Modified patch attached)
Otherwise, in both cases, the original condition might result in FALSE.
if (($vid = arg(0)) || ($vid=variable_get('taxonomy_menu_hide_module_page', FALSE)?arg(0):FALSE)) {
Second:
If 'Hide link to module page' is set to true, the pathauto setting for Taxonomy menu path settings must not be
categories/[vocab-raw]/[cat-raw]
but
[vocab-raw]/[cat-raw]
otherwise, the 'module page' is somehow back.
This is not very obvious in this whole patching thing.
Code suggestion, which awfully isn't really dynamic but an approach:
set the $settings['patterndefault'] according to the 'Hide link to modul page' selection state.
(NOT included in the patch, just wanted to discuss that first)
Comment #16
CoPut commentedThis patch doesn't applies any changes to nodes location generation function. So taxonomy menu doesn't generates right breadcrumbs. Those breadcrumbs contains no vocab item and items paths ignores paths generation rules of original patch.
To solve this I've changed _taxonomy_menu_node_view(&$node, &$vocabs) function. Here new function and helper function I added to siplify my code:
Comment #17
summit commentedHi,
Will this patch be committed please? Pathauto - Taxonomy menu is a great combination!
greetings,
Martijn
Comment #18
pelicani commentedLooking at code, quickly, and don't see anywhere the category title (term->name) is used in the URL.
I thought it was trying to removed the 'module' and change the vocab and term into a abc string.
If y'all have moment to explain what I'm missing, I'd be appreciative.
We have hacked the module and were going to contribute, but this thread seems to cover some of the same function.
Just want to get a clear if I need a new thread or if this will do.
summarize: sync path auto with tax_menu so they use the same link.
Comment #19
jenlamptonI have an existing site, with aliases already created for all my term pages. Example: taxonomy/term/5 is aliased to 'regions'
After installing this module, all the links to these pre-existing pages are in the form: category/1/5 and do not reflect any of the existing aliases.
This site has a lot of value in it's SEO and replacing the links in my main navigation with something new is not an option. Is there any way we can make this module smart enough to use what's already there, rather than trying to do it's own thing? Can't it use the url function, or drupal_get_path_alias to build the links? Hard coding seems silly.
Thanks,
Jen
Comment #20
asak commentedCan anyone confirm the latest patch works smoothly?
Comment #21
indytechcook commentedThere seems to be a duplicate effort. #192493: Using path aliases with menu paths I need confirmation that this patch works correctly. Then I can create a release for one of the two patches.
Comment #22
indytechcook commentedI will commit this in a D5 Dev version this Friday if no one from #192493: Using path aliases with menu paths is object to it. I suspect they won't be considering this adds the hide vocabulary feature.
Comment #23
summit commentedHi,
I use the functionality like taxonomy_menu/vid/tax_id_level1/tax_id_level2/tax_id_level3 fully. I would very much still like to do this.
It's a great way to have a hierarchical solution depending on the depth of the term. Like explained in http://drupal.org/node/192493#comment-633741
In my situation:
If there is a tax_id on level 3, then the url should be view_3
If there is a tax_id on level 2, then the url should be view_2
If there is a tax_id on level 1, then the url should be view_1.
I have used this on my website www.wintersport-accommodaties.nl (dutch).
Hopefully this is still possible after this change :)
Greetings,
Martijn
Comment #24
indytechcook commentedSummit, please try the patch out and let me know. I don't have ANY D5 experience and am relying on the community to support this version. That being said, I took a look at the patch, and it looks like you have to turn on the functionality.
Can someone please answer summit's concern.
Comment #25
indytechcook commentedThis is part of the latest DEV. Please test. I implemented this in conjunction with #192493: Using path aliases with menu paths.
Comment #26
sansui commentedHi indy,
I'm using the latest version, changed my paths in path auto and generated the new aliases for my taxonomy menus....
Seems to work when I'm displaying a taxonomy in a block with my panels, but when I have the menu provided from the module in my primary links, it still shows up as category/* etc
Comment #27
lakyljuk commentedSame problem here.
Comment #28
JacobSingh commentedI have the same issue... It seems the code is actually commented out in the .inc file
-Jacob
Comment #29
indytechcook commentedI'll be happy to update the code.
Jacob, Where in the code is it commented out? I will uncomment and commit. Or you can submit a patch.
Thanks,
Neil
Comment #30
TomChiverton commentedhere's a patch, as suggested, but my menu block hasn't change. Maybe some cache has to time out or be invalidated somewhere ?
Comment #31
indytechcook commentedThanks, Tom. I commited these changes. The DEV should be created tomorrow. Please let me know and I'll add to stabe.
Comment #32
summit commentedHi,
Will this also work for D6 please, or is this already tackled for D6?
Greetings,
Martijn
Comment #33
TomChiverton commentedI've tried toggling the cache on and off in admin, performance and it's not made the menu change.
I'm also a little surprised that the $alias variable that my patch now allows to be set, seemingly from calling pathauto, isn't actually used anywhere.
But I'm not sure how it's meant to work, so don't know if that's the real fault ?
Comment #34
arlinsandbulte commentedThis issue is very old and has been at "postponed (maintainer needs more info)" for a very long time.
I am going to close it out by marking as fixed.
If someone thinks this is still valid, go ahead and re-open.