unexpected '{' in asset_panels.module on line 21

wildwildwaist - March 16, 2008 - 06:16
Project:Asset
Version:5.x-2.0-beta1
Component:Asset Panels
Category:bug report
Priority:normal
Assigned:ezra-g
Status:closed
Description

hi,
I guess this has already been fixed, but just in case ...
I downloaded and set up the asset module and enabled asset panels ... I got a message error warning me for an " unexpected '{' " on line 21 of the asset_panels.module ...

here's what the line looked like :
if (function_exists(i18n_get_lang) {

how I obviously fixed it :
if (function_exists(i18n_get_lang)) {

#1

ezra-g - March 20, 2008 - 21:12
Title:")" missing ... » unexpected '{' in asset_panels.module on line 21

Using the latest checkout from DRUPAL-5 (which is version 5.x-2.0-beta1) I'm also getting this error. I would submit a patch, but I'm not clear on where the syntax error actually is since PHP still reports an error on line 21 with lines 19-24 commented out.

#2

Alex UA - March 24, 2008 - 00:58
Status:active» patch (code needs review)

Here's a patch for this...

AttachmentSize
asset_panels.patch.txt665 bytes

#3

ezra-g - March 26, 2008 - 00:51
Status:patch (code needs review)» patch (code needs work)

This did not apply:

Hunk #1 FAILED at 18.

Thanks for this patch -- I apologize for not catching your note about not submitting bug reports to this component without a patch.

#4

ezra-g - March 26, 2008 - 00:53
Assigned to:Anonymous» ezra-g

I'l reroll this in a moment.

#5

ezra-g - March 26, 2008 - 00:54
Status:patch (code needs work)» patch (code needs review)

This resolved the issue for me.

AttachmentSize
234805.patch770 bytes

#6

Roger López - April 5, 2008 - 22:26
Status:patch (code needs review)» fixed

committed to 5.x-2.0-dev

#7

Anonymous (not verified) - April 19, 2008 - 22:31
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.