Closed (fixed)
Project:
ImageField
Version:
5.x-2.0-rc6
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Mar 2008 at 12:22 UTC
Updated:
12 May 2008 at 20:28 UTC
Jump to comment: Most recent file
Comments
Comment #1
jpetso commentedThat issue has been found before and is already fixed in recent CVS checkouts, it won't appear in future imagefield releases (so 5.x-2.0-rc6 should be the last one with this error).
Comment #2
douggreen commentedThe user can still set the max_number_images when multiple is set, however, this value is really meaningless. May I suggest that you not use $field['widget']['max_number_images'] at all when $field['multiple'] is set. I've attached an alternate patch (against RC6).
Comment #3
jpetso commentedThe "min/max number of images" settings only make sense with multiple values - for single values it's automatically 1/1 (when required) or 0/1 (when not required). The point of the whole thing is that people with multiple values can't do more than 3 fields for example when they otherwise would be able to do arbitrarily many.
So, your patch makes little sense to me, especially since it has no effect on the single value case at all. Could you explain *why* max_number_images is meaningless when multiple is set, and how this is supposed to make more sense with your patch applied?
Comment #4
dopry commentedComment #5
jody lynnPlease make a new release candiate from 5--2 since in RC6 single image imagefields do not work at all (pretty serious bug I think).
Comment #6
sun+1, please create a new RC7.
Comment #7
jpereza commentedOne more vote for creating a new version RC7.
Comment #8
sunClarification: Requests to create a RC7 are unrelated to this patch. This patch is CNW, but current development snapshot is RTBC (ready for a new official release)!
Comment #9
dopry commentedthis is fixed in CVS.