Drupal 6.1, Guestbook from CVS.

With just site guestbook enabled can't delete or edit entries. The links for that seem wrong: guestbook/%252Fdelete/0. (Entering guestbook/delete/0 works.)

This happens because $uid is null everywhere; guestbook_menu passes array(0) as page arguments and guestbook_page takes $account and passes $account->uid forward.

Attached patch just checks for null uid in theme_guestbook_entry, and corrects the links in that case.

Should the uid be allowed to be null at all?

CommentFileSizeAuthor
delete_and_comment.diff1.3 KBwrwrwr

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Postponed (maintainer needs more info)

Guestbook id 0 is the site guestbook. All ids greater than 0 refer to user guestbooks. Could you please double-check if you still encounter this issue with the current RC1?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Postponed (maintainer needs more info) » Fixed

Without further information I must guess this issue has already been fixed in the meanwhile.

wrwrwr’s picture

wrwrwr commented

Confirmed, problem no longer exists with version 6.x-1.0-rc1. Sorry for not getting to this earlier.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.