I must say that most of the admin pages, tables and blocks
looks good for RTL site using with this theme out of the box.

I started to add RTL fixes to the nodes and comments
I'm still having so troubles with menus & bullets

Attached what I've done so far (not much)
And a screenshot of how my experimental Hebrew site look like with the current patch

I'll add some more soon :-)

CommentFileSizeAuthor
#9 ulproblem.png6.34 KBlameei
#5 fourseasons.zip31.09 KBoptalgin
#2 style-rtl.zip1.04 KBoptalgin
style-rtl.zip1.21 KBoptalgin
4s_rtl.jpg79.75 KBoptalgin

Comments

derjochenmeyer’s picture

derjochenmeyer commented

cool, thanks for posting... here is another issue about rtl support ..

http://drupal.org/node/225253

optalgin’s picture

optalgin commented
StatusFileSize
new style-rtl.zip1.04 KB

Some updates:

  • Sidebar menu bullets
  • Forum page and comments

Known Issues:

  • Menu bullets of 3rd & 4th level nesting dashed line not indented
  • Forum: user field, picture and name

I also have issues with IE6, right sidebar is printed at bottom of content
but this looks like a problem that has nothing to do with the RTL changes

derjochenmeyer’s picture

derjochenmeyer commented

for the ie issue just decrease the width of the column by 1 or 2 percent .. in ie-fix.css

optalgin’s picture

optalgin commented

Thanks for the IE6 tip, I just read that in other page few seconds ago :-)
but now I face another thing I'm not sure how to implement

in page.tpl.php there is this code

  <!--[if lt IE 7]>
    <style type="text/css" media="all">@import "<?php print base_path() . path_to_theme(); ?>/fix-ie.css";</style>
  <![endif]-->

I wish to change that file for RTL but I'm not sure how to set a condition
Do you think something like that might work??

<?php if (in_array ($language, array("ar", "fa", "he", "ur", "yi") ) ) { ?>
   <!--[if lt IE 7]>
   <style type="text/css" media="all">@import "<?php print base_path() . path_to_theme(); ?>/fix-ie-rtl.css";</style>
   <![endif]-->
<?php } else { ?>
   <!--[if lt IE 7]>
   <style type="text/css" media="all">@import "<?php print base_path() . path_to_theme(); ?>/fix-ie.css";</style>
   <![endif]-->
<?php } ?>

Anyway I'll test IE6 hacks soon, I need to find a computer with this browser installed

Thanks for your help

optalgin’s picture

optalgin commented
Title: RTL support » Four seasons theme, RTL support
StatusFileSize
new fourseasons.zip31.09 KB

I'm attaching my latest changes of RTL support for this theme
I also added a block region called "above content"
Most of the issues from my above post are still open (TBD)

lameei’s picture

lameei commented

Thanks for your efforts. have tested this on IE6?

lameei’s picture

lameei commented

I did a test for IE6 there is major problems. you can use Multiple_IE to install different versions of IE on the same computer. here is thee link: http://tredosoft.com/Multiple_IE

optalgin’s picture

optalgin commented

thanks for your comments

Please note that this version is incomplete, I have converted only what I needed
and haven't got the time (yet) to fix all problems

I have a running RTL site using this theme and I have no major problems with IE6,IE7,FF2,FF3
can you be more specific, please describe (or attach screen shot) the problems you encountered

Thanks for the link, this is really useful :-)

lameei’s picture

lameei commented
StatusFileSize
new ulproblem.png6.34 KB

Actually i have paste the contents on ie-fix-rtl into ie-fix so the problems have been solved. but there is one problem in ie7 and it is clear in attached picture. the circles and triangles are not positioned well. this happens in collapsed menus only in IE.

This is another software which you can use to test your site on different versions of ie: http://on10.net/blogs/sarahintampa/IETester-Helps-You-Test-Your-Site/
and here is a link which will take a snapshot of your site on different OS and browsers:
http://browsershots.org/

optalgin’s picture

optalgin commented

There is a problem with the 3rd level of the menu and above
I will try to fix this soon

You are also welcome to try and fix it in style-rtl.css
I think the problem is somewhere in this part

.sidebar ul li { 
  background-image: url("img/menu-leaf.gif");
  background-repeat: no-repeat;
  margin-right: 0;	
  padding:0 1.5em 0 1.5em;		
}

.sidebar ul li.expanded {
  background-image: url("img/menu-expanded.gif");	
  background-repeat: no-repeat;
}

.sidebar ul li.collapsed {
  background-image: url(img/menu-collapsed-rtl.gif);
  background-repeat: no-repeat;
  background-position: 100% 0.6em;
}

.sidebar ul li ul li {
  margin-right: -1.5em;
  padding:0 3.0em 0 1.5em;
}

.sidebar ul li ul li ul li {
  margin-right: -3.0em;
  padding:0 4.5em 0 4.5em;
}

.sidebar ul li ul li ul li ul li {
  margin-right: -4.5em;
  padding:0 6.0em 0 1.5em;
}


.sidebar ul li,
.sidebar ul li.expanded,
.sidebar ul li.collapsed {
   background-position: 15.4em 0.6em;
}

.sidebar ul li ul li,
.sidebar ul li ul li.expanded,
.sidebar ul li ul li.collapsed {
  background-position: 13.9em 0.6em;
}

.sidebar ul li ul li ul li,
.sidebar ul li ul li ul li.expanded,
.sidebar ul li ul li ul li.collapsed {
  background-position: 13.9em 0.6em;
}
derjochenmeyer’s picture

derjochenmeyer commented

thanks a lot for the work that you are doing on rtl ... i would be happy to include style-rtl.css in a future version of four seasons ...

optalgin’s picture

optalgin commented

I am happy to work with this theme.. This is an amazing theme!..
I wish I had more time to dedicate for it :-)

lameei’s picture

lameei commented

There is a problem with the 3rd level of the menu and above

I have added the following to fix-is CSS file the problem solved for 3rd level. for the other levels it shuold be the same.

.sidebar ul li ul li ul li ul li {
background-position: 11.8em 0.6em;
}