Please enter any reports from testing the new release. http://drupal.org/node/235128

Some questions:

-- Do the batch editing functions need their own permission?
-- Do the batch editing functions need stricter data validation?
-- Does anything break?

Comments

agentrickard’s picture

I forgot to add a batch action for editing the administrative theme. Here it is:

  // Change the administrative theme.
  $themes = list_themes();
  ksort($themes);
  $options[] = t('Use domain default theme');
  foreach ($themes as $key => $value) {
    $options[$key] = $key;
  }
  $batch['admin_theme'] = array(
    '#form' => array(  
      '#title' => t('Administrative theme'),
      '#type' => 'select',
      '#options' => $options,
      '#description' => t('Select the administrative theme for this domain.'),
    ),
    '#domain_action' => 'domain_conf',
    '#system_default' => variable_get('admin_theme', 0),
    '#variable' => 'admin_theme',
    '#meta_description' => t('Set the administrative themes for all domains.'),
    '#data_type' => 'string',    
    '#weight' => -8,
  );    
agentrickard’s picture

Version: 5.x-1.0 » 5.x-1.1beta

I have some code, to be committed, which adds validate handlers to the batch functions.

agentrickard’s picture

anonymous and site_frontpage batch are not defined correctly. Use

    '#system_default' => variable_get('site_frontpage', 'node'),
    '#system_default' => variable_get('anonymous', 'Anonymous'),
agentrickard’s picture

Small fix to domain_admin.inc (lines 710 - 723):

    $form['domain_form']['domain_form_elements'] = array(
      '#type' => 'checkboxes',
      '#default_value' => variable_get('domain_form_elements', array('options', 'delete', 'comment_settings', 'path')),
      '#options' => $options,
      '#description' => t('Some elements may not be editable for all users due to permission restrictions, specifically <em>authoring</a> and menu</em> settings.'),
    );
  }
  $default = variable_get('domain_behavior', DOMAIN_INSTALL_RULE);
  $form['domain_node'] = array(
    '#type' => 'fieldset',
    '#title' => t('Domain node types'),
    '#collapsible' => TRUE
  );  
  $form['domain_node']['intro'] = array('#value' => t('<p>Check the content types that should be published to all affiliates when new content is created.  <br /><em>NOTE: These settings only apply if the "New content settings" option is set to "Only show on selected sites."</em></p>'));
agentrickard’s picture

theme_domain_theme_reset and theme_domain_conf_reset both need the url() function:

  if (!empty($data)) {
    $output .= '<p>'. t('You may <a href="!url">erase these settings</a> to restore the default behavior.', array('!url' => url('admin/build/domain/conf-reset/'. $domain['domain_id']))) .'</p>';
  }
agentrickard’s picture

Status: Active » Closed (fixed)