Download & Extend

Reference to missing functions (book_pick_book_submit()

Project:Drupal core
Version:7.x-dev
Component:user interface text
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

we have the following comment in the code:

<?php
/**
* Implementation of hook_form_alter(). Adds the book fieldset to the node form.
*
* @see book_pick_book_submit()
* @see book_submit()
*/
function book_form_alter(&$form, $form_state, $form_id) {
?>

the problem is that neither book_pick_book_submit() nor book_submit() seem to exist.

The references were added in revision 1.429, as part of pwolanin's mega book patch, but removed with this issue: http://drupal.org/node/160039

It may not be enough to remove the two lines of comment. Maybe the documentation that was part of the removed issues should be put back instead.

Comments

#1

Version:6.x-dev» 7.x-dev
Component:book.module» user interface text

This is still an issue for the d7 docs, moving to the documentation queue.

#2

Status:active» needs review

* Adds the book fieldset to the node form.

This describes what the function does
AttachmentSizeStatusTest resultOperations
234684-block_form_alter-docs.patch448 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 21,004 pass(es).View details

#3

Status:needs review» needs work

The last submitted patch, 234684-block_form_alter-docs.patch, failed testing.

#4

Status:needs work» needs review

#2: 234684-block_form_alter-docs.patch queued for re-testing.

#5

Status:needs review» fixed

Committed to CVS HEAD. Thanks.

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here