Download & Extend
CiviCRM Subscribe » Issues

CiviCRM 2.0 compatibility

Posted by alimc29 on March 18, 2008 at 6:47pm
Project:CiviCRM Subscribe
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:critical
Assigned:douggreen
Status:closed (fixed)

Issue Summary

Are there any plans as of yet (or are either of the dev snapshots) for this module to be compatible with CiviCRM 2.0?

(with installation of 2.0, I get Fatal error: Call to undefined function crm_get_groups() in /modules/civicrm_subscribe/civicrm_subscribe.module on line 138)

Login or register to post comments

Comments

#1

Posted by alimc29 on March 18, 2008 at 7:08pm

Just to follow up, it looks like this function is replaced by civicrm_groups_get( $params )
(http://wiki.civicrm.org/confluence/display/CRMDOC/Group+APIs)

#2

Posted by grobot on October 22, 2008 at 10:42am

http://forum.civicrm.org/index.php/topic,3008.0.html is a CiviCRM forum thread on migrating API code from 1.x to 2.x

#3

Posted by that0n3guy on March 19, 2008 at 8:16pm

I may have created a duplicate issue http://drupal.org/node/234066. Different error though.

It seems there are many of us that want/need this for civicrm 2.x. Maybe we should all pitch in some cash to get'r done.

#4

Posted by chrismott on March 23, 2008 at 7:13am
Assigned to:Anonymous» chrismott
Status:active» needs review

I have jumped in here and ported the 5.x-1.2 code to use the new v2 api in CiviCRM 2.0. It needs thorough testing and a review before using for a production site. Please give it a test run.

A couple changes of note:

  • Method of creating hash values has changed since v2 API doesn't expose the CiviCRM contact hash value (http://forum.civicrm.org/index.php/topic,2814.0.html). I didn't fully understand rationale behind previous design so there may be a problem I haven't considered yet.
  • Handling of matching contact search on subscription submit, for the cases of multiple matches, partial matches and no matches was updated along with the new api. Correct behaviour should be verified for your different use cases.

The Drupal repository should probably be branched so that users can download either Drupal 5.0 + CiviCRM 1.9 or Drupal 5.0 + CiviCRM 2.0 versions. The Drupal 6.0 branch won't have this need since it will only be Drupal 6.0 + CiviCRM 2.1+

AttachmentSize
civicrm_subscribe.module.5.x-1.2.patch 10.48 KB

#5

Posted by grobot on April 16, 2008 at 12:30am

subscribe

#6

Posted by Owen Barton on May 5, 2008 at 4:17pm
Version:5.x-1.2» 5.x-1.x-dev
Component:Miscellaneous» Code
Status:needs review» reviewed & tested by the community

This patch works for me. I have updated the patch to the latest DRUPAL-5 code.

AttachmentSize
235904.patch 11.02 KB

#7

Posted by Owen Barton on May 5, 2008 at 5:32pm

Actually that patch does include a couple of additional fixes I found.

#8

Posted by douggreen on May 14, 2008 at 2:08am

Grugnog, you have CVS commit rights to this project. If you've tested the patch, can you please commit it too? Thanks!

#9

Posted by mlecha on May 16, 2008 at 7:46pm

subscribe

Working Drupal 5.7 with CiviCRM 2.0.

#10

Posted by douggreen on June 20, 2008 at 12:19pm
Status:reviewed & tested by the community» needs work

Thanks for getting this started. But there's still debugging code in the patch. And I want a patch that works with both 1.0 and 2.0 versions. I've got a client that needs this done, so hopefully a new patch will be posted (and committed) today.

#11

Posted by douggreen on June 20, 2008 at 3:07pm
Assigned to:chrismott» douggreen
Status:needs work» needs review

Please try the attached patch, and the new civicrm20compat module.

I believe that CiviCRM 2.0 has double-opt-in features. Is this module needed anymore?

AttachmentSize
235904.patch 2.94 KB

#12

Posted by sonicthoughts on June 22, 2008 at 2:45am

this is still more powerful than the civi-subscriber logic. for example, it allows an email upon subscription. i also think the do_not_email logic is better.

#13

Posted by webdev2 on October 8, 2008 at 7:25pm
Priority:normal» critical

Sort of a newbie question, I see the "+" and "-" in the patch. Am I supposed to add the "+" lines in the referenced function and delete the "-" lines?

#14

Posted by webdev2 on October 8, 2008 at 8:13pm

I added patch and still am getting a blank display to this page

ANy ideas??

#15

Posted by fm on October 9, 2008 at 4:29am

Is this also CiviCRM 2.1 compatible?

#16

Posted by Owen Barton on October 16, 2008 at 11:13pm
Category:support request» feature request

Updated patch to full CiviCRM 2.x compatibility (not using thecivicrm20compat module). If we still want to support CiviCRM 1.x, perhaps this could be committed as a 2.x branch?

AttachmentSize
235904.patch 13.39 KB

#17

Posted by webdev2 on October 21, 2008 at 5:09pm

Does this last path (Oct 16, #16) require the previous patches be applied or can I go straight from the downloaded module to this patch?

Also, is there an easier way to apply a patch than to go through each line by line manually and making the change?

Thanks!

#18

Posted by Owen Barton on October 24, 2008 at 6:29am

@webdev2,
This is a complete patch, that should apply cleanly on the 5.x-1.x-dev branch code.

To apply the patch please see http://drupal.org/patch/apply - no need to apply manually!

#19

Posted by webdev2 on October 24, 2008 at 2:04pm

Holy crap, will that save some time. Many thanks!

#20

Posted by sonicthoughts on November 6, 2008 at 9:03pm

sorry - can you clarify is this is working with drupal 6 + civicrm 2.1? Is it necessary still?

Also - can the subscription email confirmation be customized per group?

thanks,

S.

#21

Posted by bcobin on December 17, 2008 at 10:30pm

Drupal 5.12
CiviCRM 2.0.7

I just get a white screen upon submit, using the patch from #16. The user does get added to the group, but hitting 'return' on the white page url just exposes the form in a page and we're back where we started. (My signup form is in a block.)

This should be such a simple (and really, really important) function; why is everything in CiviCRM such an absolute nightmare?

Thanks for trying anyway... :(

#22

Posted by douggreen on January 28, 2009 at 5:45pm
Status:needs review» fixed

I applied the patch, tested, created a new branch and new tag. The DRUPAL-5--2 branch now supports CCRM 2.0! Thanks!

#23

Posted by fm on January 30, 2009 at 8:13pm

Just CiviCRM 2.0, or CiviCRM 2.x (including the current version, CiviCRM 2.1; and the soon to be released v2.2)?

#24

Posted by grobot on January 30, 2009 at 11:49pm

@fm: As CiviCRM v2.1+ is only compatible with D6 for now, you'd need the 6.x-dev version, and this patch seems to be against the 5.x code.

#25

Posted by System Message on February 13, 2009 at 11:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here