load markers in chunks

Bdragon committed the override API version feature in http://drupal.org/cvs?commit=106525

This patch adds back & instead of & for xhtml strict validation and rerolls the patch for the other two features.

I still need to code and patch gmap_settings_ui.inc to provide an interface for these settings, but a preliminary review would be great! :)

@tom I am hand editing one line out of the patch file which is another feature relating to location module. That may be the cause of your grief. I'll reroll with the & fix and test the patch before I upload.

@bdragon they allow for d5 js compressor support. The d5 js compressor is a bit of a hack, but is fairly popular. None of the gmap js seems to be compatible. I haven't investigated that myself in detail so I'm not sure why. However behavior shouldn't change for unhacked / regular d5 installs with those changes as they are the default parameters of drupal_add_js(), except the last parameter which is ignored in drupal 5, but was left as a placeholder for the d6 js compressor.

If you are unhappy with this change, I'll investigate wtf the precise issue is with gmap's js and the d5 js compressor.

We're using this one btw: http://drupal.org/node/149402#comment-565834

The numbers in the diff chunk headers also need tweaking if lines are add/removed from diff files. I've tested this applies to head correctly.

I also fixed the & in check_url() issue.

Don't forget js/markerloader_chunks.js from comment #1.

@Bdragon let me know how to proceed with the d5 js-compressor compatibility feature.

Bevan/

This patch includes additions to the admin settings UI to adjust the chunk markerloader settings and the Google Maps API Version string.

It also has some UI tweaks for consistency of field titles.

I also changed the default map zoom and center settings to be World-centric with America centered, as per most world maps (instead of Mediterranean centric -- which makes no sense).

I reworked a part of the markermanager code to be a little clearer to read and more efficient, and added some documentation.

This patch is feature complete and IMO, pending more review and testing, is RTBC. Please let me know if you agree Bdragon, as I have a queue of other tasks and patches waiting on this being committed.

Thanks,
Bevan/

I found the bad javascript that broke JS-compressor compatibility

js-compressor compatibility is fixed in CVS head. load marker chunks is covered in http://drupal.org/node/238872 however leaving this open in case we need to split 238872

That was an issue when I was developing the chunkMarkerLoader, see the lines added to js/gmap_marker.js in http://drupal.org/files/issues/238872_4.patch from http://drupal.org/node/238872#comment-895638.

I hadn't realized that that would be adding to the time taken to add each marker, and will test loading 100 400 and 800 markers without chunkMarkerLoader. I suspect it's still necessary, although we could up the chunk_threshold.