Embeded views using teaser lists lack pagnation [#236134]

Yet again I find myself using this great module on another site, and I noticed that the embedded views were not paginating. I modified the taxonomy_menu.inc function _taxonomy_menu_page to pass in the pagination parameters, and it worked great.

      // about line #285
      $output = views_build_view('embed',
        views_get_view(variable_get('taxonomy_menu_show_views_'. $vid, '')),
        $arguments, FALSE, NULL);

      $view = views_get_view(variable_get('taxonomy_menu_show_views_'. $vid, ''));
      $output = ($view) ? views_build_view('embed', $view, $arguments,$view->use_pager, $view->nodes_per_page) : '';

I haven't the time to test this with other view display types. This could lead to grief when using exposed filters or sorting in the table view type.

Comment	File	Size	Author
#4	patch_taxonomy_menu.patch	609 bytes	jmlavarenne

Comments

Comment #1

gpantanetti commented 19 March 2008 at 16:02

Thank you SO much! I've applied this patch to my taxonomy menu module and it works like a charm (I do not need to use exposed filters or table views at this moment).

Comment #2

alan d. commented 2 April 2008 at 23:41

I forgot to set the view url, which would almost certainly mean that the exposed filters and sorting would break things. Thus the full code would be:

      // Embed the views output into the page
      $view = views_get_view(variable_get('taxonomy_menu_show_views_'. $vid, ''));
      if ($view) {
        // set $view->url to current page
        $view->url = $_GET['q'];
        $output = views_build_view('embed', $view, $arguments,$view->use_pager, $view->nodes_per_page);
      }
      else {
        $output = '';
      }