This patch removes all those nasty hard coded forms from comment.module's user Comment Control.

Robin

CommentFileSizeAuthor
#10 moderation_forms.patch4.48 KBrobin monks
#8 commentform.patch4.04 KBrobin monks
#7 commentforms_0.patch4.08 KBrobin monks
#6 commentforms.patch4.08 KBrobin monks
#5 Comment.Control.hardcode..patch3.96 KBrobin monks
#4 Comment.Control.hardcode_1.patch3.96 KBrobin monks
#2 Comment.Control.hardcode_0.patch3.96 KBrobin monks
Comment.Control.hardcode.patch4.02 KBrobin monks

Comments

robin monks’s picture

robin monks commented

Oh, and I've test this, and it works.

Robin

robin monks’s picture

robin monks commented
StatusFileSize
new Comment.Control.hardcode_0.patch3.96 KB

A bug I missed (thanks UnConeD!).

Robin

drumm’s picture

drumm
he/him
Location NY, US
commented

I read over the code quickly and this caught my eye:

+  $filter    = db_fetch_object($result);
+  $filter[0] = t('-- threshold --');

Even though PHP might not complain we should prolly decide on array or object.

robin monks’s picture

robin monks commented
StatusFileSize
new Comment.Control.hardcode_1.patch3.96 KB

Good point, I missed that.

Robin

robin monks’s picture

robin monks commented
StatusFileSize
new Comment.Control.hardcode..patch3.96 KB

Drumm hath found another bug...

Robin

robin monks’s picture

robin monks commented
StatusFileSize
new commentforms.patch4.08 KB

Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls

Robin

robin monks’s picture

robin monks commented
StatusFileSize
new commentforms_0.patch4.08 KB

Final Version, removes 4 unneeded functions. Tested to work. Please comment.

Robin

robin monks’s picture

robin monks commented
StatusFileSize
new commentform.patch4.04 KB

Yelp, wrong patch....

jose reyero’s picture

jose reyero commented

After applying this patch, the "threshold" drop-down is gone.

robin monks’s picture

robin monks commented
StatusFileSize
new moderation_forms.patch4.48 KB

There was a glitch in the patch that caused the threshhold dropdown never to display. This version fixes that, although moderation may be broken already by Moshe's patch (as it won't work with, or without, this patch).

Robin

killes@www.drop.org’s picture

killes@www.drop.org commented

The patch looks very nice becasue it removes a lot of crufty code. I've no time to test it, though.

dries’s picture

dries commented

This patch is likely to be deprecated when the new form API is ready. I'm OK with it but haven't tested it yet.

drumm’s picture

drumm
he/him
Location NY, US
commented

I think this can only make the form converting job easier. Lets go ahead and put this patch in once reviewed unless anyone working directly on the new form api objects.

killes@www.drop.org’s picture

killes@www.drop.org commented

Dries, please commit I can't bear it to see that crufty code in Drupal.

robin monks’s picture

robin monks commented
Status: Needs review » Reviewed & tested by the community

Placing in queue per Dries.

Robin

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)